Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Add separate job to check doc/logprint/subtree #639

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@Fuzzbawls
Copy link
Collaborator

Fuzzbawls commented Jun 19, 2018

Break out a new job to do the basic linting that check-dock.py and
logprint-scanner.py did.

Also add new scripts to check the sanity of
any git subtrees and to check that new pull requests don't contain any
trailing whitespace.

Also, remove the outdated slack notification callback

[Travis] Add separate job to check doc/logprint/subtree
Break out a new job to do the basic linting that check-dock.py and
logprint-scanner.py did.

Also add new scripts to check the sanity of
any git subtrees and to check that new pull requests don't contain any
trailing whitespace.

Also, remove the outdated slack notification callback

@Fuzzbawls Fuzzbawls force-pushed the Fuzzbawls:2018_travis-lint-job branch to 6f695b5 Jun 19, 2018

@Mrs-X

Mrs-X approved these changes Jun 28, 2018

Copy link
Collaborator

Mrs-X left a comment

Can't test this obviously, but since the Travis build for this succeeded and the new scripts are from upstream I utACK and merge...

@Mrs-X Mrs-X merged commit 6f695b5 into PIVX-Project:master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mrs-X added a commit that referenced this pull request Jun 28, 2018

Merge #639: [Travis] Add separate job to check doc/logprint/subtree
6f695b5 [Travis] Add separate job to check doc/logprint/subtree (Fuzzbawls)

Tree-SHA512: f6d35050703be87664f78e4072a4026bd54a7cd50d88d323b76c906bacf43ebf424f83f1d6b8838cd20069fa2e17cafe74cb89848177464dac66bff4491f83a9

@wafflebot wafflebot bot removed the review label Jun 28, 2018

@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator Author

Fuzzbawls commented Jun 28, 2018

The travis job that was run against this PR IS the test ;)

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

[Travis] Add separate job to check doc/logprint/subtree
Break out a new job to do the basic linting that check-dock.py and
logprint-scanner.py did.

Also add new scripts to check the sanity of
any git subtrees and to check that new pull requests don't contain any
trailing whitespace.

Also, remove the outdated slack notification callback

Github-Pull: PIVX-Project#639
Rebased-From: 6f695b5

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.