Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Stop using dummy strings in clientversion.cpp #735

Merged
merged 1 commit into from Oct 7, 2018

Conversation

@Fuzzbawls
Copy link
Collaborator

commented Oct 7, 2018

This changes the "dummy" GIT_COMMIT_ID and GIT_COMMIT_DATE strings used in archive packages to use live values instead of static placeholders.

Useful when compiling in an isolated/base environment with an archive produced using make dist from a fully connected environment.

@Fuzzbawls Fuzzbawls added this to the 3.2.0 milestone Oct 7, 2018

@ghost ghost assigned Fuzzbawls Oct 7, 2018

@ghost ghost added the review label Oct 7, 2018

@Mrs-X
Mrs-X approved these changes Oct 7, 2018
Copy link
Collaborator

left a comment

utACK, and since it's the same code as upstream (Bitcoin) I'll merge if nobody complains during the next 30 minutes :-)

@Mrs-X Mrs-X merged commit cab33db into PIVX-Project:master Oct 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mrs-X added a commit that referenced this pull request Oct 7, 2018
Merge #735: [Qt] Stop using dummy strings in clientversion.cpp
cab33db Stop using dummy strings in clientversion (Fuzzbawls)

Tree-SHA512: 7513fc0580f3eba45c085fffd0bf682b947268773dc0bf440926012768dc30ef70ee1acd63b21a51250a72118ca780a62d22e387af1a5797ada2847638805a71

@ghost ghost removed the review label Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.