Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor bignum header file into several files #744

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Warrows
Copy link
Collaborator

Warrows commented Oct 11, 2018

Closes #717

@wafflebot wafflebot bot added the review label Oct 11, 2018

@Fuzzbawls
Copy link
Collaborator

Fuzzbawls left a comment

Concept ACK

However, some styling changes are needed after doing an initial once-over look.

Show resolved Hide resolved src/Makefile.am Outdated
Show resolved Hide resolved src/Makefile.am Outdated
Show resolved Hide resolved src/libzerocoin/bignum_gmp.cpp
Show resolved Hide resolved src/libzerocoin/bignum_openssl.cpp

@Warrows Warrows force-pushed the Warrows:zerocoin_bignum_refactor branch Oct 12, 2018

@Warrows

This comment has been minimized.

Copy link
Collaborator Author

Warrows commented Oct 12, 2018

Styling changes done.

@Warrows Warrows added this to the 3.2.0 milestone Nov 16, 2018

@Warrows Warrows force-pushed the Warrows:zerocoin_bignum_refactor branch to 80ea9dd Dec 26, 2018

@Fuzzbawls Fuzzbawls modified the milestones: 3.2.0, Future Jan 6, 2019

@furszy

This comment has been minimized.

Copy link
Collaborator

furszy commented Mar 5, 2019

Concept ACK.

@furszy furszy referenced this pull request Mar 6, 2019

Closed

[GMP] getuint256 crash fix. #829

@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator

Fuzzbawls commented Apr 1, 2019

needs rebase

@Warrows Warrows force-pushed the Warrows:zerocoin_bignum_refactor branch 2 times, most recently from 0906ebf to d91ad90 Apr 1, 2019

@Warrows Warrows force-pushed the Warrows:zerocoin_bignum_refactor branch from d91ad90 to 4e4975b Apr 1, 2019

@Warrows

This comment has been minimized.

Copy link
Collaborator Author

Warrows commented Apr 1, 2019

Rebased.

@Fuzzbawls Fuzzbawls referenced this pull request Apr 10, 2019

Open

Refactor bignum.h #717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.