Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Fix a windows only crash when r-clicking a proposal #826

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@Warrows
Copy link
Collaborator

Warrows commented Mar 2, 2019

The problem seems to be related to a stack corruption issue occuring within Qt and only for windows builds. Further investigation is required but this is a suitable fix for now and there is no need to have the r-click doing the same job as the l-click in this situation.
Fix #823.
Thanks to @CryptoDev-Project for report and suggested fix.

[Qt] Fix a windows only crash when r-clicking a proposal
The problem seems to be related to a stack corruption issue
occuring within Qt and only for windows 64 builds. Further
investigation is required but this is a suitable fix for now
and there is no need to have the r-click doing the sae job as
the l-click in this situation.

@Warrows Warrows added this to the 3.2.0 milestone Mar 2, 2019

@Warrows Warrows self-assigned this Mar 2, 2019

@wafflebot wafflebot bot removed the Bug label Mar 2, 2019

@Fuzzbawls
Copy link
Collaborator

Fuzzbawls left a comment

ACK 0015d08

Tested on Windows 10 Pro

@Fuzzbawls Fuzzbawls merged commit 0015d08 into PIVX-Project:master Mar 11, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Fuzzbawls added a commit that referenced this pull request Mar 11, 2019

Merge #826: [Qt] Fix a windows only crash when r-clicking a proposal
0015d08 [Qt] Fix a windows only crash when r-clicking a proposal (warrows)

Tree-SHA512: 7e9507e4ffbbca6b41d9c9b18d31f7ebfddf01d5abbfd083b2fcbf6d7d398c20391bdc4fc4903c8d1b338d0c78929920264eb6352bbcaa9b2baf1c11df965cc5

@wafflebot wafflebot bot removed Bug review labels Mar 11, 2019

This was referenced Mar 11, 2019

@Warrows Warrows deleted the Warrows:2019_fix_823 branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.