Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove BOOST_FOREACH #830

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Warrows
Copy link
Collaborator

Warrows commented Mar 7, 2019

Using language for ( : ) should be the same or better in terms of performance and it removes some dependencies on boost.

Warrows added some commits Mar 6, 2019

[Refactoring] Replace BOOST FOREACH with for :
Done using following script:

-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp
./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-

@wafflebot wafflebot bot added the review label Mar 7, 2019

@Fuzzbawls Fuzzbawls added this to the Future milestone Mar 19, 2019

@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator

Fuzzbawls commented Mar 19, 2019

Concept ACK

Always good to migrate away from Boost-specific functions if the same functionality can be achieved in the standard c++ library. That said, this should be held off until after the 3.2.0 release so as to avoid multiple rebases due to conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.