Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Fix improperly parented walletView and segmentation fault on QT 5.10 #900

Merged
merged 1 commit into from May 18, 2019

Conversation

meyer9
Copy link

@meyer9 meyer9 commented May 15, 2019

The walletView element should be parented to walletStack instead of the WalletFrame.

@meyer9
Copy link
Author

meyer9 commented May 15, 2019

Force pushed to change commit message.

@meyer9 meyer9 changed the title Fix #789 [UI] Fix improperly parented walletView and segmentation fault on QT 5.10 May 15, 2019
Copy link

@Warrows Warrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a4205f2

Copy link

@Mrs-X Mrs-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the WalletView definition this makes sense.
Nice find 👍

ACK a4205f2 and merging...

@Mrs-X Mrs-X merged commit a4205f2 into PIVX-Project:master May 18, 2019
Mrs-X added a commit that referenced this pull request May 18, 2019
…fault on QT 5.10

a4205f2 [UI] Fix improperly parented walletView. (Julian Meyer)

Tree-SHA512: ba523274a9e336a884f097dcff5a0e47e294517254350287dd0c2572c63010e63a33734707bcdca753f454f85c4bbe052817172b719e7ac66bcdbdef71d151a2
@Fuzzbawls Fuzzbawls added the GUI label May 18, 2019
@Fuzzbawls Fuzzbawls added this to the 3.3.0 milestone May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants