Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hyphen-minus (-) instead of en-dash #110

Merged
merged 1 commit into from Nov 20, 2019
Merged

Use hyphen-minus (-) instead of en-dash #110

merged 1 commit into from Nov 20, 2019

Conversation

@rjc
Copy link
Contributor

rjc commented Nov 15, 2019

This makes the file ASCII-only

This makes the file ASCII-only
@PJK

This comment has been minimized.

Copy link
Owner

PJK commented Nov 19, 2019

Hi @rjc, I have no problem with this change, but could you please explain why ASCII-only is a good thing?

(the CI failure seems unrelated)

@rjc

This comment has been minimized.

Copy link
Contributor Author

rjc commented Nov 20, 2019

Hi @PJK,

Thanks for taking the time to respond.

libcbor has recently been imported into OpenBSD base and, whilst looking at the README.md with the base vi(1), which isn't multibyte-aware, I saw this:

2014\xe2\x80\x932017

The issue, small as it may, also manifest itself while looking at the file using CVSweb:

2014–2017

Given that the LICENSE.md file, where the text has been imported from, is ASCII-only, and that (c) character is also represented in ASCII, rather than ©, it would be nice to have ASCII-only README file.

Why ASCII-only is a good thing? Smaller, cleaner, clearer - i.e. security!). Even "modern" vi clones, suffer from multibyte-related issues. So yes, worse is better! :^)

That aside, as per above, the change would allow for usage of base vi(1) without hurting my eyes ;^)

Yes, the CI failure is most definitely unrelated.

@PJK

This comment has been minimized.

Copy link
Owner

PJK commented Nov 20, 2019

Makes sense, thanks!

@PJK PJK merged commit 56a43b1 into PJK:master Nov 20, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.