Do not build two shared libraries #72
Conversation
Without this patch, when building with make -j1 cmake would create and install two shared libraries libcbor.so and libcbor.so.0.0.0 instead of creating libcbor.so as a symlink. This broke verification of reproducible builds. See https://reproducible-builds.org/ for why this matters. Also, (like before) do not install libcbor.a because static linking is bad for maintainability (all programs have to be re-built with fixed libraries)
|
autogenerated provenance graph for |
|
This is great, thank you, @bmwiedemann! And well spotted with the static library. As a side question, is there some automated check I can use to keep libcbor verification-friendly in the future? |
|
You can try to avoid the ~12 basic indeterminisms described in https://github.com/bmwiedemann/theunreproduciblepackage (e.g. 'race' in this case) But you don't really need to, because I'll watch whatever goes into openSUSE ;-) |
Without this patch, when building with
make -j1cmake would create and install two shared libraries
libcbor.soandlibcbor.so.0.0.0instead of creating
libcbor.soas a symlink.This broke verification of reproducible builds.
See https://reproducible-builds.org/ for why this matters.
Also, (like before) do not install libcbor.a
because static linking is bad for maintainability
(because all programs have to be re-built with fixed libraries)
This PR was done while working on reproducible builds for openSUSE.