New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unattended runs for custom Plugins #151 #275

Merged
merged 7 commits into from Feb 25, 2017

Conversation

Projects
None yet
3 participants
@nul800sebastiaan
Contributor

nul800sebastiaan commented Aug 6, 2016

I thought I'd kickstart #151 by starting simple:

  • if you specify --plugins myplugin,iis then those two plugins will run (note that IIS is a built-in plugin)
  • Plugins need to accept an empty response if they want to run unattended, for example if (string.IsNullOrEmpty(response) == false && response != "c".ToLowerInvariant()) return;
  • The plugin itself can then can use a config file or some other way to get some optional values so that it can run without prompting the user for anything

I know all this can be made much nicer and I'm happy to put some effort in if this get accepted and we can discuss some more on what else needs to happen to improve this.

@rkerber

This comment has been minimized.

Collaborator

rkerber commented Aug 9, 2016

I'm not sure if multiple plugins should be ran at once. The app isn't really designed to run more than a single plugin at once, and i'm not sure what use there could be to run multiple plugins at once since right now they would share the arguments for what to run for, and their certs would overwrite each other.

I'll take a look at it and test it out to see how it works.

@rkerber rkerber added the testing label Aug 9, 2016

@nul800sebastiaan

This comment has been minimized.

Contributor

nul800sebastiaan commented Aug 9, 2016

Ah yes, didn't think of that! Sure, limited to 1 plugin should be fine actually. I can update the PR.

nul800sebastiaan added some commits Aug 21, 2016

@nul800sebastiaan

This comment has been minimized.

Contributor

nul800sebastiaan commented Aug 21, 2016

Updated to only use a single plugin when it's specified on the command line!

@nul800sebastiaan

This comment has been minimized.

Contributor

nul800sebastiaan commented Feb 19, 2017

Updated in 0ede740. Turns out that I had a small mistake in the logic there, all plugins would run regardless of what was specified on the command line, Now if you specify --plugin MyPlugin only that one will run.

Allow for signer email to be specified on command line
Don't require enter press after we're done when a plugin is specified
@nul800sebastiaan

This comment has been minimized.

Contributor

nul800sebastiaan commented Feb 19, 2017

And to be able to run fully unattended, even on first run, you can now specify a SignerEmail and you're no longer required to press Enter to exit after the program is done (only if a plugin is specified on the command line).
Commit: 68a25e5

@tsimmons

This comment has been minimized.

tsimmons commented Feb 20, 2017

Does anyone know if any of these pushes will be merged? Is there a more current version/build than the 1.9.1 with the re-enabling TLS 1.0 commit from July 30, 2016?

@nul800sebastiaan nul800sebastiaan added this to the v1.9.2 milestone Feb 25, 2017

@nul800sebastiaan nul800sebastiaan merged commit a0bb4b2 into PKISharp:master Feb 25, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nul800sebastiaan nul800sebastiaan deleted the nul800sebastiaan:plugins-cmdline-arg branch Feb 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment