Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UML icon #392

Open
wants to merge 10 commits into
base: master
from

Conversation

@ptrkcsk
Copy link

commented Feb 18, 2019

Fixes #323


fileIcons

@PKief PKief force-pushed the PKief:master branch 3 times, most recently from 8651a6d to 59d9f43 Mar 24, 2019
ptrkcsk added 5 commits Apr 19, 2019
@@ -802,5 +802,11 @@ export const fileIcons: FileIcons = {
{ name: 'vim', fileExtensions: ['vimrc', 'gvimrc', 'exrc'] },
{ name: 'nest', fileNames: ['nest-cli.json', '.nest-cli.json', 'nestconfig.json', '.nestconfig.json'] },
{ name: 'moonscript', fileExtensions: ['moon'] },
{
name: 'uml',
// https://marketplace.visualstudio.com/items?itemName=jebbs.plantuml#user-content-supported-formats

This comment has been minimized.

Copy link
@PKief

PKief Jul 14, 2019

Owner

Could you please remove the comment here?

This comment has been minimized.

Copy link
@ptrkcsk

ptrkcsk Jul 14, 2019

Author

Sure!

I'm curious, why? I thought it would be helpful for anyone wondering where the extensions came from.

This comment has been minimized.

Copy link
@PKief

PKief Jul 14, 2019

Owner

I understand your intention, but it's not the right place for me to add this information. If someone is really interested in where the extensions came from he/she can use "git blame" or search through the issues in GitHub. I want to avoid that data has to be transferred and stored which is only meta information and does not improve the functionality of the extension. Thanks for removing it 😉

This comment has been minimized.

Copy link
@ptrkcsk

ptrkcsk Jul 14, 2019

Author

Got it.

ptrkcsk added 2 commits Jul 14, 2019
@PKief PKief force-pushed the PKief:master branch from b750ff3 to 3d1e6b3 Aug 29, 2019
ptrkcsk added 2 commits Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.