Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netlify file icon #396

Merged
merged 30 commits into from May 18, 2019
Merged

Add netlify file icon #396

merged 30 commits into from May 18, 2019

Conversation

leggsimon
Copy link
Contributor

Adds the file icon for netlify.toml files.

Shown here in the light and dark formats:

screen shot 2019-02-24 at 16 41 55

screen shot 2019-02-24 at 16 42 32

@PKief PKief changed the title add netlify file icon Add netlify file icon Mar 10, 2019
@PKief PKief self-requested a review March 18, 2019 21:29
@PKief PKief force-pushed the master branch 3 times, most recently from 8651a6d to 59d9f43 Compare March 24, 2019 14:13
@leggsimon
Copy link
Contributor Author

Any possibility of this going in? Are you waiting on anything else regarding this?

@PKief
Copy link
Owner

PKief commented May 18, 2019

I adjusted the icon to have a proper color:

colored netlify icon

I prefer it if the icons are rather colorful than black and white. This makes the theme more lively and we don't need 2 icons.

@PKief PKief merged commit ab21e49 into PKief:master May 18, 2019
@leggsimon
Copy link
Contributor Author

@PKief Fantastic, you’re right that does look nicer. Thanks for that!

@leggsimon leggsimon deleted the add-netlify-file-icon branch May 20, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants