Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model icon + Icon for reactive state angular project #420

Closed
wants to merge 6 commits into from

Conversation

@rbalet
Copy link
Contributor

commented Mar 26, 2019

  1. Thought maybe could have the myModel.model.ts a specific icon (Now look like any other ts file)
    image
  2. I use reactive state within angular (with akita framework) and I thought we could use the ngrx icon for that. (The query, store and state)
    image
  3. Add json folder icon
    image
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
src/icons/folderIcons.ts Outdated Show resolved Hide resolved
src/icons/folderIcons.ts Outdated Show resolved Hide resolved
This reverts commit 557a542.
@rbalet

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

I revert the change about the ngrx.
Make completely sense for me what you said about activating the Icon Package.

rbalet added 2 commits May 13, 2019
@PKief PKief force-pushed the PKief:master branch from b750ff3 to 3d1e6b3 Aug 29, 2019
@rbalet

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

@PKief Any news? should I close this pull request?

@PKief

This comment has been minimized.

Copy link
Owner

commented Sep 29, 2019

Hi @rbalet the model icon will not be merged because it's too specific. A file called "model.ts" should always have the default typescript icon. But the idea of having a folder icon for "json" could be nice. For now, leave the PR open ;)

@rbalet

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

@PKief I understand, but I realize I've poorly explaned my self. I thought only the file that had a xxx.model.ts and not only model.ts. Does it make more cense for you, or do you want me to remove it? (last question about that, promyse)

image

@PKief

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2019

@rbalet It would be better if you could remove it. I like the idea, but I think it's better to have the TypeScript icon here.

@rbalet rbalet referenced this pull request Oct 1, 2019
@rbalet rbalet closed this Oct 1, 2019
@rbalet

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

#543 for the new pull request about json folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.