New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update: odk-ppp #8

Closed
joeflack4 opened this Issue Jun 22, 2018 · 2 comments

Comments

Projects
2 participants
@joeflack4
Contributor

joeflack4 commented Jun 22, 2018

Description

In requirements.txt, ppp-web is currently using an old requirement: https://github.com/joeflack4/pmix/zipball/working_ppp

This line should now be: odk-ppp

Tasks

  • Update the requirements, and do pip3 install -r requirements.txt (possibly may need to add the --upgrade flag, I'm not sure).
  • Test manually to make sure things work. Try converting some files.
@tulvit

This comment has been minimized.

Show comment
Hide comment
@tulvit

tulvit Jun 27, 2018

Member

Done, tested. Works like a charm:

$ python3 -m ppp 1.xlsx -p minimal > 1.html /usr/bin/python3: No module named ppp $ pip3 install -r https://raw.githubusercontent.com/PMA-2020/ppp-web/develop-readme/requirements.txt $ python3 -m ppp 1.xlsx -p minimal > 1.html
*and it produced a valid file

Also, please check my edits to README.md file.

Changes - probably, both files (README.md and requirements.txt) could be merged to a development branch.

Member

tulvit commented Jun 27, 2018

Done, tested. Works like a charm:

$ python3 -m ppp 1.xlsx -p minimal > 1.html /usr/bin/python3: No module named ppp $ pip3 install -r https://raw.githubusercontent.com/PMA-2020/ppp-web/develop-readme/requirements.txt $ python3 -m ppp 1.xlsx -p minimal > 1.html
*and it produced a valid file

Also, please check my edits to README.md file.

Changes - probably, both files (README.md and requirements.txt) could be merged to a development branch.

@joeflack4 joeflack4 added this to To do in ppp-web Jul 9, 2018

@joeflack4

This comment has been minimized.

Show comment
Hide comment
@joeflack4

joeflack4 Jul 9, 2018

Contributor

@tulvit Thanks!

Changes merged in #10

Contributor

joeflack4 commented Jul 9, 2018

@tulvit Thanks!

Changes merged in #10

@joeflack4 joeflack4 closed this Jul 9, 2018

ppp-web automation moved this from To do to Done Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment