Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
Choose a Base Repository
rsim/oracle-enhanced
PMACS/oracle-enhanced
CNXTEoEorg/oracle-enhanced
CoryFoy/oracle-enhanced
Envek/oracle-enhanced
Epictetus/oracle-enhanced
Eric-Guo/oracle-enhanced
Extremia/oracle-enhanced
InteNs/oracle-enhanced
NathanZook/oracle-enhanced
OIT-ADS-Web/oracle-enhanced
PavelPenkov/oracle-enhanced
PseudoCorps/oracle-enhanced
SathishRaju/oracle-enhanced
SukanyaK/oracle-enhanced
SunghanKim/oracle-enhanced
Xylakant/oracle-enhanced
Ziaw/oracle-enhanced
aake/oracle-enhanced
abeger/oracle-enhanced
adammcfadden/oracle-enhanced
afterthought/oracle-enhanced
agilestep/oracle-enhanced
aleksandrs-ledovskis/oracle-enhanced
alexrothenberg/oracle-enhanced
amatsuda/oracle-enhanced
amr0th/oracle-enhanced
andfx/oracle-enhanced
andrewstucki/oracle-enhanced
ankitdhingra/oracle-enhanced
anthonycarlos/oracle-enhanced
antonjenkins/oracle-enhanced
arrimedia/oracle-enhanced
avinmathew/oracle-enhanced
banyan/oracle-enhanced
barendt/oracle-enhanced
basking2/oracle-enhanced
bbozo/oracle-enhanced
bbrowning/oracle-enhanced
bcluca/oracle-enhanced
bdurand/oracle-enhanced
bfabry/oracle-enhanced
blackjk3/oracle-enhanced
bober/oracle-enhanced
brogers/oracle-enhanced
brusius/oracle-enhanced
byung82/oracle-enhanced
caron10/oracle-enhanced
cdinger/oracle-enhanced
chadburrus/oracle-enhanced
chriger/oracle-enhanced
claptimes5/oracle-enhanced
cmoran92/oracle-enhanced
cnotechappell/oracle-enhanced
coopecyrillus93/oracle-enhanced
cosine/oracle-enhanced
cpjolicoeur/oracle-enhanced
ctreatma/oracle-enhanced
ctroncoso/oracle-enhanced
curzonj/oracle-enhanced
dabla/oracle-enhanced
dalton/oracle-enhanced
daqo/oracle-enhanced
dasnixon/oracle-enhanced
davesmylie/oracle-enhanced
davinlagerroos/oracle-enhanced
dbishai/oracle-enhanced
dcarbone/oracle-enhanced
diasjorge/oracle-enhanced
dimakura/oracle-enhanced
dmann/oracle-enhanced
dodecaphonic/oracle-enhanced
drobny/oracle-enhanced
duffyjp/oracle-enhanced
ebeigarts/oracle-enhanced
erickpereira/oracle-enhanced
ernestonakamura/oracle-enhanced
erum21/oracle-enhanced
evgenyrahman/oracle-enhanced
foliosus/oracle-enhanced
frisoft/oracle-enhanced
gacha/oracle-enhanced
gregclar/oracle-enhanced
gurugeek/oracle-enhanced
hiukkanen/oracle-enhanced
ijcd/oracle-enhanced
ilmotta/oracle-enhanced
ishmael/oracle-enhanced
itsmechlark/oracle-enhanced
ixiaoshayu/oracle-enhanced
jadon1979/oracle-enhanced
jamiepg1/oracle-enhanced
janisvi/oracle-enhanced
jchilders/oracle-enhanced
jeffperrin/oracle-enhanced
jestraw/oracle-enhanced
jkl1337/oracle-enhanced
joe81/oracle-enhanced
joekhoobyar/oracle-enhanced
jordanbwiebe/oracle-enhanced
jorhan/oracle-enhanced
joshuawatson/oracle-enhanced
jprewitt/oracle-enhanced
jsl/oracle-enhanced
jspooner/oracle-enhanced
jwylder/oracle-enhanced
kamipo/oracle-enhanced
kares/oracle-enhanced
keit/oracle-enhanced
kennyj/oracle-enhanced
knightq/oracle-enhanced
lanusau/oracle-enhanced
leandrogualter/oracle-enhanced
litianzzk/oracle-enhanced
luisparravicini/oracle-enhanced
lustremedia/oracle-enhanced
mateusg/oracle-enhanced
mikewoodhouse/oracle-enhanced
mkurkov/oracle-enhanced
mleone/oracle-enhanced
mmayernick/oracle-enhanced
modcracker/oracle-enhanced
mrreynolds/oracle-enhanced
mscottford/oracle-enhanced
mulvaney/oracle-enhanced
mwilson/oracle-enhanced
mxhold/oracle-enhanced
nathanvda/oracle-enhanced
nbcu6db-dev/oracle-enhanced
neojin/oracle-enhanced
nerdytenor/oracle-enhanced
nessur/oracle-enhanced
odynvolk/oracle-enhanced
openface/oracle-enhanced
pa657/oracle-enhanced
pablohenrique6/oracle-enhanced
pankajagarwal/oracle-enhanced
patrickmcelwee/oracle-enhanced
pforsyth/oracle-enhanced
pivotal-sharknado/oracle-enhanced
pivotal-slate/oracle-enhanced
pospeev/oracle-enhanced
powerpak/oracle-enhanced
predlac/oracle-enhanced
qwertme/oracle-enhanced
ratecity/oracle-enhanced
rdgmatos/oracle-enhanced
retoo/oracle-enhanced
riyengar8/oracle-enhanced
rkabir/oracle-enhanced
robhu/oracle-enhanced
rpmehta26/oracle-enhanced
rrooding/oracle-enhanced
rschumann/oracle-enhanced
rshell/oracle-enhanced
rsutphin/oracle-enhanced
rwc9u/oracle-enhanced
saberma/oracle-enhanced
sanelson2000/oracle-enhanced
sarsena/oracle-enhanced
savonarola/oracle-enhanced
scottschulthess/oracle-enhanced
senguidanos/oracle-enhanced
sergey-kucher/oracle-enhanced
simi/oracle-enhanced
slamotte/oracle-enhanced
soon0009/oracle-enhanced
substars/oracle-enhanced
sunndog/oracle-enhanced
swaroopmurthy/oracle-enhanced
tamersalama/oracle-enhanced
tarmotalu/oracle-enhanced
tenderlove/oracle-enhanced
thiaguerd/oracle-enhanced
timferro/oracle-enhanced
tinylox/oracle-enhanced
tiss/oracle-enhanced
tomasv/oracle-enhanced
torgoton/oracle-enhanced
troyk/oracle-enhanced
tsteveAs/oracle-enhanced
tzumby/oracle-enhanced
udn/oracle-enhanced
villi/oracle-enhanced
vipulnsward/oracle-enhanced
vivekprahlad/oracle-enhanced
vsanta/oracle-enhanced
wconrad/oracle-enhanced
webgago/oracle-enhanced
wemrysi/oracle-enhanced
weyhmueller/oracle-enhanced
wfschmitt/oracle-enhanced
wjdix/oracle-enhanced
wndxlori/oracle-enhanced
xaop/oracle-enhanced
yahonda/oracle-enhanced
ygliuvt/oracle-enhanced
yoonseokho/oracle-enhanced
yulihh1/oracle-enhanced
zzti/oracle-enhanced
Nothing to show
...
Choose a Head Repository
rsim/oracle-enhanced
PMACS/oracle-enhanced
CNXTEoEorg/oracle-enhanced
CoryFoy/oracle-enhanced
Envek/oracle-enhanced
Epictetus/oracle-enhanced
Eric-Guo/oracle-enhanced
Extremia/oracle-enhanced
InteNs/oracle-enhanced
NathanZook/oracle-enhanced
OIT-ADS-Web/oracle-enhanced
PavelPenkov/oracle-enhanced
PseudoCorps/oracle-enhanced
SathishRaju/oracle-enhanced
SukanyaK/oracle-enhanced
SunghanKim/oracle-enhanced
Xylakant/oracle-enhanced
Ziaw/oracle-enhanced
aake/oracle-enhanced
abeger/oracle-enhanced
adammcfadden/oracle-enhanced
afterthought/oracle-enhanced
agilestep/oracle-enhanced
aleksandrs-ledovskis/oracle-enhanced
alexrothenberg/oracle-enhanced
amatsuda/oracle-enhanced
amr0th/oracle-enhanced
andfx/oracle-enhanced
andrewstucki/oracle-enhanced
ankitdhingra/oracle-enhanced
anthonycarlos/oracle-enhanced
antonjenkins/oracle-enhanced
arrimedia/oracle-enhanced
avinmathew/oracle-enhanced
banyan/oracle-enhanced
barendt/oracle-enhanced
basking2/oracle-enhanced
bbozo/oracle-enhanced
bbrowning/oracle-enhanced
bcluca/oracle-enhanced
bdurand/oracle-enhanced
bfabry/oracle-enhanced
blackjk3/oracle-enhanced
bober/oracle-enhanced
brogers/oracle-enhanced
brusius/oracle-enhanced
byung82/oracle-enhanced
caron10/oracle-enhanced
cdinger/oracle-enhanced
chadburrus/oracle-enhanced
chriger/oracle-enhanced
claptimes5/oracle-enhanced
cmoran92/oracle-enhanced
cnotechappell/oracle-enhanced
coopecyrillus93/oracle-enhanced
cosine/oracle-enhanced
cpjolicoeur/oracle-enhanced
ctreatma/oracle-enhanced
ctroncoso/oracle-enhanced
curzonj/oracle-enhanced
dabla/oracle-enhanced
dalton/oracle-enhanced
daqo/oracle-enhanced
dasnixon/oracle-enhanced
davesmylie/oracle-enhanced
davinlagerroos/oracle-enhanced
dbishai/oracle-enhanced
dcarbone/oracle-enhanced
diasjorge/oracle-enhanced
dimakura/oracle-enhanced
dmann/oracle-enhanced
dodecaphonic/oracle-enhanced
drobny/oracle-enhanced
duffyjp/oracle-enhanced
ebeigarts/oracle-enhanced
erickpereira/oracle-enhanced
ernestonakamura/oracle-enhanced
erum21/oracle-enhanced
evgenyrahman/oracle-enhanced
foliosus/oracle-enhanced
frisoft/oracle-enhanced
gacha/oracle-enhanced
gregclar/oracle-enhanced
gurugeek/oracle-enhanced
hiukkanen/oracle-enhanced
ijcd/oracle-enhanced
ilmotta/oracle-enhanced
ishmael/oracle-enhanced
itsmechlark/oracle-enhanced
ixiaoshayu/oracle-enhanced
jadon1979/oracle-enhanced
jamiepg1/oracle-enhanced
janisvi/oracle-enhanced
jchilders/oracle-enhanced
jeffperrin/oracle-enhanced
jestraw/oracle-enhanced
jkl1337/oracle-enhanced
joe81/oracle-enhanced
joekhoobyar/oracle-enhanced
jordanbwiebe/oracle-enhanced
jorhan/oracle-enhanced
joshuawatson/oracle-enhanced
jprewitt/oracle-enhanced
jsl/oracle-enhanced
jspooner/oracle-enhanced
jwylder/oracle-enhanced
kamipo/oracle-enhanced
kares/oracle-enhanced
keit/oracle-enhanced
kennyj/oracle-enhanced
knightq/oracle-enhanced
lanusau/oracle-enhanced
leandrogualter/oracle-enhanced
litianzzk/oracle-enhanced
luisparravicini/oracle-enhanced
lustremedia/oracle-enhanced
mateusg/oracle-enhanced
mikewoodhouse/oracle-enhanced
mkurkov/oracle-enhanced
mleone/oracle-enhanced
mmayernick/oracle-enhanced
modcracker/oracle-enhanced
mrreynolds/oracle-enhanced
mscottford/oracle-enhanced
mulvaney/oracle-enhanced
mwilson/oracle-enhanced
mxhold/oracle-enhanced
nathanvda/oracle-enhanced
nbcu6db-dev/oracle-enhanced
neojin/oracle-enhanced
nerdytenor/oracle-enhanced
nessur/oracle-enhanced
odynvolk/oracle-enhanced
openface/oracle-enhanced
pa657/oracle-enhanced
pablohenrique6/oracle-enhanced
pankajagarwal/oracle-enhanced
patrickmcelwee/oracle-enhanced
pforsyth/oracle-enhanced
pivotal-sharknado/oracle-enhanced
pivotal-slate/oracle-enhanced
pospeev/oracle-enhanced
powerpak/oracle-enhanced
predlac/oracle-enhanced
qwertme/oracle-enhanced
ratecity/oracle-enhanced
rdgmatos/oracle-enhanced
retoo/oracle-enhanced
riyengar8/oracle-enhanced
rkabir/oracle-enhanced
robhu/oracle-enhanced
rpmehta26/oracle-enhanced
rrooding/oracle-enhanced
rschumann/oracle-enhanced
rshell/oracle-enhanced
rsutphin/oracle-enhanced
rwc9u/oracle-enhanced
saberma/oracle-enhanced
sanelson2000/oracle-enhanced
sarsena/oracle-enhanced
savonarola/oracle-enhanced
scottschulthess/oracle-enhanced
senguidanos/oracle-enhanced
sergey-kucher/oracle-enhanced
simi/oracle-enhanced
slamotte/oracle-enhanced
soon0009/oracle-enhanced
substars/oracle-enhanced
sunndog/oracle-enhanced
swaroopmurthy/oracle-enhanced
tamersalama/oracle-enhanced
tarmotalu/oracle-enhanced
tenderlove/oracle-enhanced
thiaguerd/oracle-enhanced
timferro/oracle-enhanced
tinylox/oracle-enhanced
tiss/oracle-enhanced
tomasv/oracle-enhanced
torgoton/oracle-enhanced
troyk/oracle-enhanced
tsteveAs/oracle-enhanced
tzumby/oracle-enhanced
udn/oracle-enhanced
villi/oracle-enhanced
vipulnsward/oracle-enhanced
vivekprahlad/oracle-enhanced
vsanta/oracle-enhanced
wconrad/oracle-enhanced
webgago/oracle-enhanced
wemrysi/oracle-enhanced
weyhmueller/oracle-enhanced
wfschmitt/oracle-enhanced
wjdix/oracle-enhanced
wndxlori/oracle-enhanced
xaop/oracle-enhanced
yahonda/oracle-enhanced
ygliuvt/oracle-enhanced
yoonseokho/oracle-enhanced
yulihh1/oracle-enhanced
zzti/oracle-enhanced
Nothing to show
Commits on Mar 01, 2012
Commits on Apr 13, 2012
Commits on Apr 14, 2012
Commits on Apr 29, 2012
Commits on Apr 30, 2012
Merge pull request #166 from yahonda/address_wrong_number_of_argument…
…s_5_for_3

Address wrong number of arguments 5 for 3
Commits on Jun 04, 2012
Commits on Jun 05, 2012
Merge pull request #173 from yahonda/address_no_method_error_column_t…
…ypes_rails4

Address NoMethodError: undefined method `column_types'
Commits on Jun 06, 2012
Merge pull request #176 from yahonda/bump_gems_rails4
rails4: Bump jeweler, ruby-plsql and ruby-oci8 gems to the latest version
Address 3 failures after #173 merged.
Rails 4 `select_all` should return `ActiveRecord::Result`
but these tests are still expecting `Array`. select_all return value casted to Array.
Commits on Jun 07, 2012
Commits on Jun 11, 2012
Commits on Jun 21, 2012
Commits on Jun 23, 2012
Commits on Jun 26, 2012
Commits on Jun 28, 2012
Commits on Jul 05, 2012
Add clear_logger in each test which set_logger executed
to address ArgumentError: wrong number of arguments (1 for 2)
Merge pull request #193 from yahonda/add_clear_logger_rails4
Add clear_logger  to address ArgumentError: wrong number of arguments (1 for 2)
Commits on Jul 17, 2012
Use arel nodes instead of raw sql for Oracle enhanced adapter.
It also addresses ORA-911 at
test_find_on_has_many_association_collection_with_include_and_conditions
Merge pull request #198 from yahonda/address_ora_911_rails_rails4
Use arel nodes instead of raw sql for Oracle enhanced adapter.
Commits on Jul 18, 2012
Clear index cache when any table dropped.
indexes method incorrecly shows non-exist indexes just after the table dropped.
Merge pull request #200 from yahonda/create_join_table_rails4
Clear index cache when any table is dropped
Commits on Jul 27, 2012
Commits on Jul 31, 2012
Address OCIError: ORA-01400 errors at the SqlBypassTest reported in i…
…ssue #188.

SqlBypass test requires a raw insert statement, which explicitly inserts
the id column with #{table_name}_seq.nextval for Oracle database
which does not have any auto_increment features.
Merge pull request #204 from yahonda/session_store_rails4
rails4: Support SqlBypassTest with Oracle
Commits on Aug 01, 2012
Merge pull request #206 from yahonda/rails4_merges_master
Merge commits made on master branch since rails4 branch cut
Commits on Aug 02, 2012
Merge pull request #207 from yahonda/address_dirty_oracle
Address test_integer_zero_to_integer_zero_not_marked_as_changed failure
Commits on Aug 20, 2012
Merge pull request #210 from yahonda/rename_deprecated_finders
Update to "activerecord-deprecated_finders"
Commits on Sep 06, 2012
Remove non exist files from gemspec
This commit addresses following errors at rails4 branch.

  Using activerecord-oracle_enhanced-adapter (1.4.1) from git://github.com/rsim/oracle-enhanced.git (at rails4)
  activerecord-oracle_enhanced-adapter at <path> did not have a valid gemspec.
  This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
  The validation message from Rubygems was:
    ["lib/active_record/connection_adapters/oracle_enhanced_activerecord_patches.rb", "lib/active_record/connection_adapters/oracle_enhanced_base_ext.rb", "lib/active_record/connection_adapters/oracle_enhanced_tasks.rb"] are not files
Commits on Sep 07, 2012
Commits on Sep 14, 2012
Commits on Sep 15, 2012
Commits on Sep 16, 2012
Merge pull request #220 from yahonda/ensure_resets_tx_state_rails4
rails4: Ensure disconnecting or reconnecting resets the transaction state
Commits on Sep 25, 2012
Support for specifying transaction isolation level with Oracle
Supported isolation levels with Oracle database are:
* `:read_committed`
* `:serializable`

These isolation levels are not supported with Oracle database:
* `:read_uncommitted`
* `:repeatable_read`

See also rails/rails@392eeec
Merge pull request #226 from yahonda/isolation_level_rails4
Support for specifying transaction isolation level with Oracle
Commits on Sep 28, 2012
Support column related schema dumper code in the AbstractAdapter
This commit addresses the NoMethodError undefined method `default_string'.
See issue#221.
Merge pull request #228 from yahonda/address_221_rails4
Support column related schema dumper code in the AbstractAdapter
Commits on Sep 29, 2012
Dump schema using new style hash
Use new hash style foobar: for dump schema.
See rails/rails#7566 also.
Commits on Oct 24, 2012
Commits on Oct 30, 2012
Address following ArgumentErrors
     Failure/Error: t.integer :id
     ArgumentError:
       you can't redefine the primary key column 'id'. To define a custom primary key, pass { id: false } to create_table.

See the following commit
rails/rails@e4790a2
Merge pull request #238 from yahonda/cannot_redefine_id_rails4
Address        you can't redefine the primary key column 'id'. To define a custom primary key, pass { id: false } to create_table.
Commits on Nov 04, 2012
Change add_index method to support following changes at Rails master
  Raise an ArgumentError when passing an invalid option to add_index
  - rails/rails@8fc5270
  Deprecate passing a string as third argument of `add_index`
  - rails/rails@7042fe2
Merge pull request #242 from yahonda/deprecated_string_index_option_r…
…ails4

Change add_index method to support changes at rails master
Commits on Nov 09, 2012
Commits on Nov 14, 2012
Merge pull request #244 from yahonda/unnecessary_warnings_rails4
Address unnecessary warnings when option set to nil
Commits on Nov 20, 2012
Merge branch 'master' into rails4_merges_master
Conflicts:
	lib/active_record/connection_adapters/oracle_enhanced_base_ext.rb
	lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb
	spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb

Conflict resolutions

  #1 lib/active_record/connection_adapters/oracle_enhanced_base_ext.rb

  This file has been removed in rails4 branch at 9369d15
  "Initial support for ActiveRecord 4. Dropping support for older versions."

  Several changes done with 3fad716c0132af0e833b2da26738642500326408 are
  merged to `lib/active_record/connection_adapters/oracle_enhanced_model.rb`

  #2 lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb

  These two commits at master branch conflict with 166bcb2

  -- Two commits at master branch
  305283a
  "Remove_column should raise an ArgumentError when no columns are passed"

  38e7b72
  "Fix broken column remove inside a change_table block."

  -- A commit at rails4 branch
  166bcb2
  "Support refactored remove_column"

  #3 spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb

  This commit done at master branch conflict with rails4.
  e35a4a0
  "Fix pending specs on Oracle 10g properly"
Merge pull request #251 from yahonda/rails4_merges_master
rails4: merges commits done at master branch into rails4 branch
Commits on Nov 21, 2012
Remove field_changed? method
Since Rails 3.2.9 and higher version only _field_changed? method should exist
rails4 branch does not support lower version of Rails, this alias_method should not exist.

This commit actually reverts part of ea66792
Merge pull request #254 from yahonda/rails4_field_changed
Remove field_changed? method from rails4 branch
Commits on Nov 26, 2012
Better fix for unnecessary warnings when option set to nil done
See also #242 #243 and rails/rails/commit/fa0aebf320995a598c5bffda729aed4429681f3a
Merge pull request #255 from yahonda/options_value_rails4
Better fix for unnecessary warnings when option set to nil done
Commits on Nov 28, 2012
Merge pull request #257 from yahonda/mismatched_indentation_rails4
Address warning: mismatched indentations at 'end' with 'if' at 134`
Commits on Dec 31, 2012
Commits on Jan 10, 2013
Rename update method to update_record, create method to create_record
to support the following commit at rails

rails/rails/commit/1f3a1fedf951dbc4b72d178e2a649c4afd2f1566
Merge pull request #273 from yahonda/issue270_rails4
Rename update method to update_record, create method to create_record
Commits on Jan 27, 2013
Merge branch 'master' into rails4_merges_master_2nd
Conflicts:
	lib/active_record/connection_adapters/oracle_enhanced_base_ext.rb
	lib/active_record/connection_adapters/oracle_enhanced_schema_dumper.rb
	spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb

Conflict resolutions:
	lib/active_record/connection_adapters/oracle_enhanced_base_ext.rb
    - `0fdeb26f` and `f50aa48` have been merged to `lib/active_record/connection_adapters/oracle_enhanced_model.rb`

	lib/active_record/connection_adapters/oracle_enhanced_schema_dumper.rb
    - `e897d63` needs ruby 1.9 hash style

  spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb
    - `e897d63` needs ruby 1.9 hash style
Merge pull request #279 from yahonda/rails4_merges_master_2nd
Merge commits done at master into rails4
Commits on Feb 21, 2013
Support allowed_index_name_length method
to reserve index name chars for internal rails operations.

Oracle enhanced adapter does not need extra length for index operations
this returns the index_name_length .

Refer rails/rails#8613 for detail.
Commits on Feb 24, 2013
Commits on Feb 25, 2013
Commits on Feb 26, 2013
Merge pull request #288 from yahonda/remove_ojdbc6
Remove ojdbc6.jar which was added by mistake
Remove ActiveRecord::Model from Oracle enhanced adapter
ActiveRecord::Model had been implemented in Rails master then reverted
in this commit.

Refer rails/rails@9e4c41c
Merge pull request #289 from yahonda/remove_ar_model_rails4
Remove ActiveRecord::Model from Oracle enhanced adapter
Commits on Mar 04, 2013
Divide ActiveRecord::ConnectionAdapters::OracleEnhancedColumnDumper
and ActiveRecord::ConnectionAdapters::OracleEnhancedSchemaDumper

To prepare merge rails4 branch into master,
these modules should be stored in separe file because
ActiveRecord::ConnectionAdapters::OracleEnhancedColumnDumper just supports
Rails 4 and does not Rails 3.2 and earlier versions.
Merge pull request #292 from yahonda/separate_column_dumper
Divide ActiveRecord::ConnectionAdapters::OracleEnhancedColumnDumper
Commits on Mar 05, 2013
Commits on Mar 08, 2013
Commits on Mar 10, 2013
Suppport prepared statements features
- prepared statements can be disabled
rails/rails@fd39847
- Created block to by-pass the prepared statement bindings.
rails/rails@9f54921
Merge pull request #295 from yahonda/unprepared_visitor
Suppport prepared statements features
Merge pull request #296 from yahonda/rails8868
Use the index name explicitly provided in a migration when reverting
Merge pull request #297 from yahonda/deprecate_connection
Deprecate #connection in favour of accessing it via the class
Commits on Mar 12, 2013
Commits on Apr 09, 2013
Merge branch 'master' into rails4_merges_master_3rd
Conflicts:
	lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb

Tab character conflicted.
Commits on Apr 10, 2013
Commits on Apr 11, 2013
Commits on May 20, 2013
Update link in README
Link to the proper `RUNNING_TESTS.md` file
Commits on Jun 25, 2013
Commits on Jun 26, 2013
Commits on Jul 11, 2013
expand VERSION file path in Ruby
as otherwise File.read with Unix style path with .. in it was failing on some Windows XP old versions
expand VERSION file path in Ruby
as otherwise File.read with Unix style path with .. in it was failing on some Windows XP old versions
Commits on Aug 12, 2013
Commits on Aug 13, 2013
Commits on Aug 14, 2013
Merge pull request #294 from unclebilly/jeweler
Remove jeweler from gemspec and remove version constraint from jeweler i...
Merge pull request #311 from kubo/master
enable inserting NULL to object type columns
Commits on Aug 16, 2013
Commits on Aug 25, 2013
Commits on Aug 26, 2013
Merge pull request #321 from kubo/master
Fix #320 'wrong number of arguments calling `bind_param` (2 for 3)' caused by #311
Commits on Sep 05, 2013
Commits on Sep 23, 2013
Commits on Sep 30, 2013
Commits on Oct 06, 2013
Address ORA-00955 error
NEW_TEST_EMPLOYEES_NO_PKEY table should be dropped
Commits on Oct 08, 2013
Commits on Oct 14, 2013
Merge branch 'master' into rails4_merges_master_4th
Conflicts:
	Gemfile
	lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb
Commits on Oct 20, 2013
Commits on Oct 24, 2013
Commits on Oct 26, 2013
support also ojdbc6.jar for Java 1.7
in case of Java 1.7 check for both ojdbc7.jar and ojdbc6.jar file in application ./lib directory, in load path and in environment PATH variable
support also ojdbc6.jar for Java 1.7
in case of Java 1.7 check for both ojdbc7.jar and ojdbc6.jar file in application ./lib directory, in load path and in environment PATH variable
Commits on Oct 27, 2013
Commits on Oct 29, 2013
Merge pull request #358 from yahonda/remove_tests_for_older_versions
Remove pendings because 1.5 and later version supports Rails4
Commits on Oct 30, 2013
Commits on Nov 01, 2013
Commits on Nov 18, 2013
Showing with 1,066 additions and 923 deletions.
  1. +5 −15 Gemfile
  2. +85 −0 History.md
  3. +35 −4 README.md
  4. +1 −0 Rakefile
  5. +1 −1 VERSION
  6. +7 −8 activerecord-oracle_enhanced-adapter.gemspec
  7. +0 −41 lib/active_record/connection_adapters/oracle_enhanced_activerecord_patches.rb
  8. +323 −61 lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
  9. +0 −121 lib/active_record/connection_adapters/oracle_enhanced_base_ext.rb
  10. +5 −0 lib/active_record/connection_adapters/oracle_enhanced_column.rb
  11. +55 −0 lib/active_record/connection_adapters/oracle_enhanced_column_dumper.rb
  12. +4 −13 lib/active_record/connection_adapters/oracle_enhanced_context_index.rb
  13. +5 −6 lib/active_record/connection_adapters/oracle_enhanced_dirty.rb
  14. +31 −16 lib/active_record/connection_adapters/oracle_enhanced_jdbc_connection.rb
  15. +9 −3 lib/active_record/connection_adapters/oracle_enhanced_oci_connection.rb
  16. +163 −232 lib/active_record/connection_adapters/oracle_enhanced_procedures.rb
  17. +18 −10 lib/active_record/connection_adapters/oracle_enhanced_schema_definitions.rb
  18. +20 −32 lib/active_record/connection_adapters/oracle_enhanced_schema_dumper.rb
  19. +54 −35 lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb
  20. +0 −17 lib/active_record/connection_adapters/oracle_enhanced_tasks.rb
  21. +1 −1 lib/active_record/connection_adapters/oracle_enhanced_version.rb
  22. +5 −74 spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
  23. +6 −3 spec/active_record/connection_adapters/oracle_enhanced_connection_spec.rb
  24. +98 −98 spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb
  25. +5 −1 spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
  26. +3 −3 spec/active_record/connection_adapters/oracle_enhanced_dbms_output_spec.rb
  27. +11 −7 spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb
  28. +56 −55 spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb
  29. +31 −9 spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb
  30. +4 −3 spec/active_record/connection_adapters/oracle_enhanced_structure_dump_spec.rb
  31. +25 −54 spec/spec_helper.rb
View
20 Gemfile
@@ -1,26 +1,15 @@
source 'http://rubygems.org'
group :development do
- gem 'jeweler', '~> 1.5.1'
+ gem 'jeweler', '~> 1.8'
gem 'rspec', '~> 2.4'
gem 'rdoc'
if ENV['RAILS_GEM_VERSION']
gem 'activerecord', "=#{ENV['RAILS_GEM_VERSION']}"
gem 'actionpack', "=#{ENV['RAILS_GEM_VERSION']}"
gem 'activesupport', "=#{ENV['RAILS_GEM_VERSION']}"
- case ENV['RAILS_GEM_VERSION']
- when /^2.0/
- gem 'composite_primary_keys', '=0.9.93'
- when /^2.1/
- gem 'composite_primary_keys', '=1.0.8'
- when /^2.2/
- gem 'composite_primary_keys', '=2.2.2'
- when /^2.3.3/
- gem 'composite_primary_keys', '=2.3.2'
- when /^3/
- gem 'railties', "=#{ENV['RAILS_GEM_VERSION']}"
- end
+ gem 'railties', "=#{ENV['RAILS_GEM_VERSION']}"
else
%w(activerecord activemodel activesupport actionpack railties).each do |gem_name|
if ENV['RAILS_GEM_PATH']
@@ -43,10 +32,11 @@ group :development do
end
end
- gem 'ruby-plsql', '>=0.4.4'
+ gem "activerecord-deprecated_finders"
+ gem 'ruby-plsql', '>=0.5.0'
platforms :ruby do
- gem 'ruby-oci8', '>=2.0.4'
+ gem 'ruby-oci8', '>=2.1.2'
end
end
View
@@ -1,3 +1,88 @@
+## 1.5.0 / 2013-11-01
+
+* Enhancements
+ * Add license in gemspec and Rakefile [#361]
+
+## 1.5.0.rc1 / 2013-10-31
+
+* Update README and HISTORY
+* No other changes since 1.5.0.beta1
+
+## 1.5.0.beta1 / 2013-10-28
+
+* Enhancements and major changes
+ * Support Rails 4.0
+ * Desupport Rails 3.2 and lower version. To support Rails 3.2, use Version 1.4.3
+ * Drop session store support [#219]
+ * Create indexes automatically for references and belongs_to [#183]
+ * Use the index name explicitly provided in a migration when reverting [#296]
+ * Rename indexes when a table or column is renamed [#286]
+ * Support refactored remove_column [#172]
+ * Support allowed_index_name_length method [#285]
+ * Remove schema prefix from sequence name if present before truncating [#155]
+ * Bumped jeweler, ruby-plsql and ruby-oci8 version [#176]
+ * Support also ojdbc6.jar for Java 1.7 [#350]
+ * Support "activerecord-deprecated_finders" [#210]
+ * Prepared statements can be disabled [#295]
+ * Ensure disconnecting or reconnecting resets the transaction state [#220]
+ * Support for specifying transaction isolation level [#226]
+ * Rename the partial_updates config to partial_writes [#234]
+ * Deprecate passing a string as third argument of add_index [#242]
+ * Rename update method to update_record, create method to create_record [#273]
+ * Deprecate #connection in favour of accessing it via the class [#297]
+ * Support SchemaCreation [#298]
+ * Add support for foreign key creation in create_table [#317]
+ * Add virtual columns support for rail4 branch [#329]
+ * Support columns_for_distinct method [#340]
+ * Clear index cache when any table dropped [#200]
+ * Clear index cache when remove_column executed [#269]
+ * Dump schema uses ruby 1.9 style hash [#229]
+ * Support _field_changed? and drop field_changed? [#182 #254]
+ * Use arel nodes instead of raw sql [#198]
+ * Raise an ArgumentError when passing an invalid option to add_index [#242]
+ * Split OracleEnhancedColumnDumper from OracleEnhancedSchemaDumper [#292]
+ * Unit test sets default_timezone = :local [#184]
+ * Support reset_pk_sequence! [#287]
+ * Remove unnecessary pendings in unit tests [#358]
+
+* Bug Fix
+ * Address ArgumentError: wrong number of arguments (5 for 3) [#166]
+ * Address NoMethodError: undefined method `column_types' [#173]
+ * Schema dumper removes table_name_prefix and table_name_suffix [#191]
+ * Add clear_logger to address ArgumentError: wrong number of arguments (1 for 2) [#193]
+ * Use Relation#to_a as Relation#all is deprecated in Rails [#203]
+ * Address Address test_integer_zero_to_integer_zero_not_marked_as_changed failure [#207]
+ * Address NoMethodError undefined method `default_string' [#221]
+ * Address you can't redefine the primary key column 'id'. To define a custom primary key, pass { id: false } to create_table [#238]
+ * Remove unnecessary DEPRECATION WARNING [#255]
+ * Assigning "0.0" to a nullable numeric column does not make it dirty [#293]
+ * Address `rake spec` abort [#353]
+ * Correct activerecord-deprecated_finders not loaded if ENV['RAILS_GEM_VERSION'] set [#353]
+
+* Known Issues
+ * Oracle Text features are not fully supported with Oracle 12c [#331]
+
+### 1.4.3 / 2013-10-24
+
+* No changes since 1.4.3.rc2
+
+### 1.4.3.rc2 / 2013-10-23
+
+* Change build procedures
+* No other changes since 1.4.3.rc1
+
+### 1.4.3.rc1 / 2013-10-19
+
+* Enhancements:
+ * Allow inserting NULL to Oracle Spatial Data Types such as MDSYS.SDO_GEOMETRY [#311]
+ * Support ojdbc7.jar JDBC Driver [#335]
+
+* Bug fixes:
+ * Fixed Gemfile to bundle update work [#294]
+ * Fixed broken links in README.md and RUNNING_TESTS.md [#303 #306]
+ * Address rename_table works if the source table created with :id => false [#336]
+ * Use expand_path to show VERSION with Windows XP
+
### 1.4.2 / 2013-03-18
* No changes since 1.4.2.rc2
View
@@ -6,11 +6,42 @@ Oracle enhanced adapter for ActiveRecord
DESCRIPTION
-----------
-Oracle enhanced ActiveRecord adapter provides Oracle database access from Ruby on Rails applications. Oracle enhanced adapter can be used from Ruby on Rails versions 2.3.x and 3.x and it is working with Oracle database versions 10g and 11g.
+Oracle enhanced ActiveRecord adapter provides Oracle database access from Ruby on Rails applications. Oracle enhanced adapter can be used from Ruby on Rails versions between 2.3.x and 4.0 and it is working with Oracle database versions from 10g to 12c.
INSTALLATION
------------
+### Rails 4
+
+Oracle enhanced adapter version 1.5 just supports Rails 4 and does not support Rails 3.2 or lower version of Rails.
+
+When using Ruby on Rails version 4 then in Gemfile include
+
+ gem "activerecord-oracle_enhanced-adapter", "~> 1.5.0"
+
+where instead of 1.5.0 you can specify any other desired version. It is recommended to specify version with `~>` which means that use specified version or later patch versions (in this example any later 1.5.x version but not 1.6.x version). Oracle enhanced adapter maintains API backwards compatibility during patch version upgrades and therefore it is safe to always upgrade to latest patch version.
+
+If you would like to use latest adapter version from github then specify
+
+ gem 'activerecord-oracle_enhanced-adapter', :git => 'git://github.com/rsim/oracle-enhanced.git'
+
+If you are using CRuby 1.9.3 or 2.0 then you need to install ruby-oci8 gem as well as Oracle client, e.g. [Oracle Instant Client](http://www.oracle.com/technetwork/database/features/instant-client/index-097480.html). Include in Gemfile also ruby-oci8:
+
+ gem 'ruby-oci8', '~> 2.1.0'
+
+If you are using JRuby then you need to download latest [Oracle JDBC driver](http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-112010-090769.html) - either ojdbc7.jar or ojdbc6.jar for Java 7, ojdbc6.jar for Java 6 or ojdbc5.jar for Java 5. And copy this file to one of these locations:
+
+ * in `./lib` directory of Rails application
+ * in some directory which is in `PATH`
+ * in `JRUBY_HOME/lib` directory
+ * or include path to JDBC driver jar file in Java `CLASSPATH`
+
+After specifying necessary gems in Gemfile run
+
+ bundle install
+
+to install the adapter (or later run `bundle update` to force updating to latest version).
+
### Rails 3
When using Ruby on Rails version 3 then in Gemfile include
@@ -115,7 +146,7 @@ If you deploy JRuby on Rails application in Java application server that support
To use jndi with Tomcat you need to set the accessToUnderlyingConnectionAllowed to true property on the pool. See the [Tomcat Documentation](http://tomcat.apache.org/tomcat-7.0-doc/jndi-resources-howto.html) for reference.
-You can find other available database.yml connection parameters in [oracle_enhanced_adapter.rb](/rsim/oracle-enhanced/blob/master/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb). There are many NLS settings as well as some other Oracle session settings.
+You can find other available database.yml connection parameters in [oracle_enhanced_adapter.rb](http://github.com/rsim/oracle-enhanced/blob/master/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb). There are many NLS settings as well as some other Oracle session settings.
### Adapter settings
@@ -140,7 +171,7 @@ If you want to change Oracle enhanced adapter default settings then create initi
In case of Rails 2 application you do not need to use `ActiveSupport.on_load(:active_record) do ... end` around settings code block.
-See other adapter settings in [oracle_enhanced_adapter.rb](/rsim/oracle-enhanced/blob/master/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb).
+See other adapter settings in [oracle_enhanced_adapter.rb](http://github.com/rsim/oracle-enhanced/blob/master/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb).
### Legacy schema support
@@ -368,7 +399,7 @@ When Apache with Phusion Passenger (mod_passenger or previously mod_rails) is us
RUNNING TESTS
-------------
-See [RUNNING_TESTS.md](/rsim/oracle-enhanced/blob/master/RUNNING_TESTS.md) for information how to set up environment and run Oracle enhanced adapter unit tests.
+See [RUNNING_TESTS.md](https://github.com/rsim/oracle-enhanced/blob/master/RUNNING_TESTS.md) for information how to set up environment and run Oracle enhanced adapter unit tests.
LINKS
-----
View
@@ -22,6 +22,7 @@ EOS
gem.homepage = "http://github.com/rsim/oracle-enhanced"
gem.authors = ["Raimonds Simanovskis"]
gem.extra_rdoc_files = ['README.md']
+ gem.license = 'MIT'
end
Jeweler::RubygemsDotOrgTasks.new
View
@@ -1 +1 @@
-1.4.2
+1.5.0
@@ -5,11 +5,12 @@
Gem::Specification.new do |s|
s.name = %q{activerecord-oracle_enhanced-adapter}
- s.version = "1.4.2"
+ s.version = "1.5.0"
s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+ s.license = 'MIT'
s.authors = [%q{Raimonds Simanovskis}]
- s.date = %q{2013-03-18}
+ s.date = %q{2013-11-01}
s.description = %q{Oracle "enhanced" ActiveRecord adapter contains useful additional methods for working with new and legacy Oracle databases.
This adapter is superset of original ActiveRecord Oracle adapter.
}
@@ -29,10 +30,9 @@ This adapter is superset of original ActiveRecord Oracle adapter.
"activerecord-oracle_enhanced-adapter.gemspec",
"lib/active_record/connection_adapters/emulation/oracle_adapter.rb",
"lib/active_record/connection_adapters/oracle_enhanced.rake",
- "lib/active_record/connection_adapters/oracle_enhanced_activerecord_patches.rb",
"lib/active_record/connection_adapters/oracle_enhanced_adapter.rb",
- "lib/active_record/connection_adapters/oracle_enhanced_base_ext.rb",
"lib/active_record/connection_adapters/oracle_enhanced_column.rb",
+ "lib/active_record/connection_adapters/oracle_enhanced_column_dumper.rb",
"lib/active_record/connection_adapters/oracle_enhanced_connection.rb",
"lib/active_record/connection_adapters/oracle_enhanced_context_index.rb",
"lib/active_record/connection_adapters/oracle_enhanced_core_ext.rb",
@@ -46,7 +46,6 @@ This adapter is superset of original ActiveRecord Oracle adapter.
"lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb",
"lib/active_record/connection_adapters/oracle_enhanced_schema_statements_ext.rb",
"lib/active_record/connection_adapters/oracle_enhanced_structure_dump.rb",
- "lib/active_record/connection_adapters/oracle_enhanced_tasks.rb",
"lib/active_record/connection_adapters/oracle_enhanced_version.rb",
"lib/activerecord-oracle_enhanced-adapter.rb",
"spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb",
@@ -89,7 +88,7 @@ This adapter is superset of original ActiveRecord Oracle adapter.
s.specification_version = 3
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
- s.add_development_dependency(%q<jeweler>, ["~> 1.5.1"])
+ s.add_development_dependency(%q<jeweler>, ["~> 1.8"])
s.add_development_dependency(%q<rspec>, ["~> 2.4"])
s.add_development_dependency(%q<activerecord>, [">= 0"])
s.add_development_dependency(%q<activemodel>, [">= 0"])
@@ -101,7 +100,7 @@ This adapter is superset of original ActiveRecord Oracle adapter.
s.add_development_dependency(%q<ruby-plsql>, [">= 0.4.4"])
s.add_development_dependency(%q<ruby-oci8>, [">= 2.0.4"])
else
- s.add_dependency(%q<jeweler>, ["~> 1.5.1"])
+ s.add_dependency(%q<jeweler>, ["~> 1.8"])
s.add_dependency(%q<rspec>, ["~> 2.4"])
s.add_dependency(%q<activerecord>, [">= 0"])
s.add_dependency(%q<activemodel>, [">= 0"])
@@ -114,7 +113,7 @@ This adapter is superset of original ActiveRecord Oracle adapter.
s.add_dependency(%q<ruby-oci8>, [">= 2.0.4"])
end
else
- s.add_dependency(%q<jeweler>, ["~> 1.5.1"])
+ s.add_dependency(%q<jeweler>, ["~> 1.8"])
s.add_dependency(%q<rspec>, ["~> 2.4"])
s.add_dependency(%q<activerecord>, [">= 0"])
s.add_dependency(%q<activemodel>, [">= 0"])
@@ -1,41 +0,0 @@
-# ActiveRecord 2.3 patches
-if ActiveRecord::VERSION::MAJOR == 2 && ActiveRecord::VERSION::MINOR == 3
- require "active_record/associations"
-
- ActiveRecord::Associations::ClassMethods.module_eval do
- private
- def tables_in_string(string)
- return [] if string.blank?
- if self.connection.adapter_name == "OracleEnhanced"
- # always convert table names to downcase as in Oracle quoted table names are in uppercase
- # ignore raw_sql_ that is used by Oracle adapter as alias for limit/offset subqueries
- string.scan(/([a-zA-Z_][\.\w]+).?\./).flatten.map(&:downcase).uniq - ['raw_sql_']
- else
- string.scan(/([\.a-zA-Z_]+).?\./).flatten
- end
- end
- end
-
- ActiveRecord::Associations::ClassMethods::JoinDependency::JoinAssociation.class_eval do
- protected
- def aliased_table_name_for(name, suffix = nil)
- # always downcase quoted table name as Oracle quoted table names are in uppercase
- if !parent.table_joins.blank? && parent.table_joins.to_s.downcase =~ %r{join(\s+\w+)?\s+#{active_record.connection.quote_table_name(name).downcase}\son}
- @join_dependency.table_aliases[name] += 1
- end
-
- unless @join_dependency.table_aliases[name].zero?
- # if the table name has been used, then use an alias
- name = active_record.connection.table_alias_for "#{pluralize(reflection.name)}_#{parent_table_name}#{suffix}"
- table_index = @join_dependency.table_aliases[name]
- @join_dependency.table_aliases[name] += 1
- name = name[0..active_record.connection.table_alias_length-3] + "_#{table_index+1}" if table_index > 0
- else
- @join_dependency.table_aliases[name] += 1
- end
-
- name
- end
- end
-
-end
Oops, something went wrong.

No commit comments for this range