Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving unit tests for network extraction functions #317

Closed
ma-sadeghi opened this issue Oct 15, 2020 · 3 comments · Fixed by #659
Closed

Improving unit tests for network extraction functions #317

ma-sadeghi opened this issue Oct 15, 2020 · 3 comments · Fixed by #659

Comments

@ma-sadeghi
Copy link
Member

Some of our methods are not properly being tested by our unit tests. I only skimmed through test_network_extraction.py, and it seems that we're not properly testing network extraction. From what I see, most of the time, we're only checking the shape of the output, whereas at the very least, I think we should check the values.

@jgostick jgostick added this to Bugfix in V2.0 Jan 25, 2021
@jgostick jgostick moved this from Bugfix to Maintenance in V2.0 Mar 8, 2021
@ma-sadeghi
Copy link
Member Author

A good way to test the output value(s) of a function is to compare its np.linalg.norm, which sort of uniquely encapsulates the image values.

@jgostick jgostick modified the milestones: v2.1, v2.0 Apr 26, 2021
@jgostick
Copy link
Member

I'm going to move this to a 2.1 issue. It's obviously important, but I think that a good thorough sweep of the unit tests is needed and that will take time and delay the release of 2.0.

@jgostick jgostick modified the milestones: v2.0, v2.1 May 21, 2021
@jgostick
Copy link
Member

I have added buncha tests for the extractions. They check for exact numerical outputs, like the right number of peaks, regions, etc.

@jgostick jgostick changed the title Improving unit tests Improving unit tests for network extraction functions Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants