Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all scripts OUT_DIR_COMMON_BASE gnostic #8

Merged
merged 1 commit into from Nov 20, 2013

Conversation

@mallardduck
Copy link

mallardduck commented Nov 20, 2013

This patch add functionality to mimic the environment variable added to
AOSP by JBQ; here goo.gl/GVT7Xl .

Previously, and without this, a build initiated by our build-pac.sh
script would work until the initial compilation would complete, upon
starting the optimizing and final zip creation it would fail to find the
OUT directory only looking directly in the source folder.

With this patch, if OUT_DIR_COMMON_BASE is null/undefined in .bashrc the
use functions the exact same as if the patch were not present, when it
is defined it returns 1 causing the patch to use OUT_DIR_COMMON_BASE as
OUT_DIR.

UPDATE: Once pulled, you have to copy the build-pac.sh from
vendor/pac/tools to the base of your source and make it an executable.
After you do that, with the changes you can test you build as normal
noting the output of the patch above the build.
Example to compare: http://pastebin.com/XZ8Mfex2

PS1: Initial Patch, Much hacks, Fix builds for self; Unsure if work for
others.
PS2: Actually make this function, less hacks; should work no mater what.
PS3: Clarity about testing patch.

TODO:

  1. Re-word patch message.
  2. Submit patch.

Change-Id: Ia224bcbf87070664cc174c2fb597590f66893b35

This patch add fucntionality to mimic the environment varible added to
AOSP by JBQ; here goo.gl/GVT7Xl .

Previously, and without this, a build initiated by our build-pac.sh
script would work until the initial compilation would complete, upon
starting the optimizing and final zip creation it would fail to find the
OUT directory only looking directly in the source folder.

With this patch, if OUT_DIR_COMMON_BASE is null/undefined in .bashrc the
use functions the exact same as if the patch were not present, when it
is defined it returns 1 causing the patch to use OUT_DIR_COMMON_BASE as
OUT_DIR.

PS1: Initial Patch, Much hacks, Fix builds for self; Unsure if work for
others.
PS2: Actually make this function, less hacks; should work no mater what.

TODO:
1. Re-word patch message.
2. Submit patch.

Change-Id: Ia224bcbf87070664cc174c2fb597590f66893b35
mallardduck added a commit that referenced this pull request Nov 20, 2013
Make all scripts OUT_DIR_COMMON_BASE gnostic
@mallardduck mallardduck merged commit 2523e0a into PMStaging:pac-4.4 Nov 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.