This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Make all scripts OUT_DIR_COMMON_BASE gnostic #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch add fucntionality to mimic the environment varible added to AOSP by JBQ; here goo.gl/GVT7Xl . Previously, and without this, a build initiated by our build-pac.sh script would work until the initial compilation would complete, upon starting the optimizing and final zip creation it would fail to find the OUT directory only looking directly in the source folder. With this patch, if OUT_DIR_COMMON_BASE is null/undefined in .bashrc the use functions the exact same as if the patch were not present, when it is defined it returns 1 causing the patch to use OUT_DIR_COMMON_BASE as OUT_DIR. PS1: Initial Patch, Much hacks, Fix builds for self; Unsure if work for others. PS2: Actually make this function, less hacks; should work no mater what. TODO: 1. Re-word patch message. 2. Submit patch. Change-Id: Ia224bcbf87070664cc174c2fb597590f66893b35
mallardduck
added a commit
that referenced
this pull request
Nov 20, 2013
Make all scripts OUT_DIR_COMMON_BASE gnostic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add functionality to mimic the environment variable added to
AOSP by JBQ; here goo.gl/GVT7Xl .
Previously, and without this, a build initiated by our build-pac.sh
script would work until the initial compilation would complete, upon
starting the optimizing and final zip creation it would fail to find the
OUT directory only looking directly in the source folder.
With this patch, if OUT_DIR_COMMON_BASE is null/undefined in .bashrc the
use functions the exact same as if the patch were not present, when it
is defined it returns 1 causing the patch to use OUT_DIR_COMMON_BASE as
OUT_DIR.
UPDATE: Once pulled, you have to copy the build-pac.sh from
vendor/pac/tools to the base of your source and make it an executable.
After you do that, with the changes you can test you build as normal
noting the output of the patch above the build.
Example to compare: http://pastebin.com/XZ8Mfex2
PS1: Initial Patch, Much hacks, Fix builds for self; Unsure if work for
others.
PS2: Actually make this function, less hacks; should work no mater what.
PS3: Clarity about testing patch.
TODO:
Change-Id: Ia224bcbf87070664cc174c2fb597590f66893b35