Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tuck arms client code back to tuck_arms_main.py #33

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@jstnhuang
Copy link

commented Feb 28, 2015

Could we add the action client code for tucking the arms back into tuck_arms_main? This is more convenient because right now, running rosrun pr2_tuck_arms_action tuck_arms.py -lt -rt just starts the action server, without doing anything, and there's no other way to easily tuck the arms without writing our own action client code.

@TheDash

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2015

Thanks.. I'm not sure what happened to it and what caused it to go away. but this is needed.

Just to confirm: this PR adds it back so the tuck_arms will tuck arms again?

@TheDash

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2015

It looks like 2055ec3

back in 2013 attempted to catkinize this package. In turn, it changed it to "tuck_arms_test" with some very shady code. Not sure why that was accepted as a PR.

@TheDash

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2015

Please put this code into tuck_arms.py. tuck_arms_main is for the action server. tuck_arms.py is the client and so the client code should interface with the server as such.

@jstnhuang

This comment has been minimized.

Copy link
Author

commented Mar 25, 2015

Should tuck_arms.py start the action server as well? I left it out so far to avoid conflicts if the tuck arms action server is already running. But it would be more convenient, I think.

k-okada added a commit to k-okada/pr2_apps that referenced this pull request Feb 14, 2018

fix tuck arm client code back to tuck_arm_main.py
at this moment, pr2_tuckarm tuck_arms.py just start action server, but we expect to run client code see http://wiki.ros.org/pr2_tuckarm
c.f. PR2/pr2_common_actions#33
@k-okada

This comment has been minimized.

Copy link
Member

commented Feb 14, 2018

we merged this code in PR2/pr2_apps#33, so

rosrun pr2_tuckarm tuck_arms.py -lt -rt

should work, instead of

rosrun pr2_tuck_arms_action tuck_arms.py -lt -rt

as described in http://wiki.ros.org/pr2_tuckarm

@k-okada k-okada closed this Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.