From 1e984b0c675a13b09624837a7a0a842ed243d52c Mon Sep 17 00:00:00 2001 From: eitsupi Date: Sun, 2 Apr 2023 02:01:27 +0000 Subject: [PATCH 1/5] ci: fix check GitHub Actions workflow --- .github/workflows/pull-request.yaml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index f80482f..be2d2b1 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -21,22 +21,21 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: ["3.7", "3.8", "3.9", "3.10"] + os: [ubuntu-latest, macos-latest, windows-latest] + python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"] steps: - name: Checkout uses: actions/checkout@v3 - uses: actions/setup-python@v4 with: - python-version: ${{ inputs.target_option }} + python-version: ${{ matrix.python-version }} - name: Install Poetry uses: snok/install-poetry@v1 - with: - version: ${{ inputs.poetry_version }} - run: poetry install - name: Test Code and Docs run: poetry run pytest - name: Upload to codecov - if: matrix.os == 'ubuntu-latest' + if: runner.os == 'ubuntu-latest' && matrix.python-version == '3.11' uses: codecov/codecov-action@v3 with: token: ${{ secrets.CODECOV_TOKEN }} From 3410a1a839d21acbffa53fd58773958a5eb026e6 Mon Sep 17 00:00:00 2001 From: eitsupi Date: Sun, 2 Apr 2023 02:03:21 +0000 Subject: [PATCH 2/5] ci: remove merge trigger which is not working --- .github/workflows/release.yaml | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 97bd0d2..a31387d 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -1,16 +1,10 @@ name: release on: - pull_request: - types: - - closed - branches: - - main workflow_dispatch: jobs: release: - # Run if we have a label `release` on a merged PR or it's run manually - if: (github.event.pull_request.merged == true && contains(github.event.pull_request.labels.*.name, 'pr-release')) || github.event_name == 'workflow_dispatch' + if: github.event_name == 'workflow_dispatch' runs-on: ubuntu-latest steps: - name: Checkout @@ -23,8 +17,6 @@ jobs: - name: Install Poetry uses: snok/install-poetry@v1 - with: - version: ${{ inputs.poetry_version }} - name: Cache Pip uses: actions/cache@v3 From 226b41a03ae8786fb91b9b8d3be93685756caea1 Mon Sep 17 00:00:00 2001 From: eitsupi Date: Sun, 2 Apr 2023 02:11:10 +0000 Subject: [PATCH 3/5] fix: more python versions --- pyproject.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pyproject.toml b/pyproject.toml index 5a28c3e..8193cd5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -7,9 +7,11 @@ authors = [ classifiers = [ "License :: OSI Approved :: Apache Software License", "Programming Language :: Python", + "Programming Language :: Python :: 3.7", "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", + "Programming Language :: Python :: 3.11", "Typing :: Typed", ] description = "Python extensions for PRQL" From 2af53242a1f7e84a43294f0b5f09350d318b8a83 Mon Sep 17 00:00:00 2001 From: eitsupi Date: Sun, 2 Apr 2023 02:16:46 +0000 Subject: [PATCH 4/5] ci: fix runner name --- .github/workflows/pull-request.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index be2d2b1..955ddfb 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -35,7 +35,7 @@ jobs: - name: Test Code and Docs run: poetry run pytest - name: Upload to codecov - if: runner.os == 'ubuntu-latest' && matrix.python-version == '3.11' + if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.11' uses: codecov/codecov-action@v3 with: token: ${{ secrets.CODECOV_TOKEN }} From a2b25cc6ffe5856cbb182cb4fccd16fe541f4dbe Mon Sep 17 00:00:00 2001 From: eitsupi Date: Sun, 2 Apr 2023 02:48:02 +0000 Subject: [PATCH 5/5] ci: remove codecov step (not working) --- .github/workflows/pull-request.yaml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index 955ddfb..008d3a2 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -34,11 +34,3 @@ jobs: - run: poetry install - name: Test Code and Docs run: poetry run pytest - - name: Upload to codecov - if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.11' - uses: codecov/codecov-action@v3 - with: - token: ${{ secrets.CODECOV_TOKEN }} - files: ./coverage.xml - fail_ci_if_error: true - verbose: true