Skip to content

suggested chang to fix issue #20 ( #25

wants to merge 2 commits into from

3 participants


As suggested, the code now uses only one query (rather than a query per device) to get all notifications. I have tested the code only locally, so please review carefully ..

andreasmueller added some commits Jan 27, 2011
@andreasmueller andreasmueller modified send_notifications_for_cert routine to decrease db load
Rather than making a query for each device, we can get all unsent
notifications for a given app with one SQL query.

The change also required a slight update of the app_spec.
@andreasmueller andreasmueller specify :select in find to avoid :read_only
The APN::Notification.find call returned read-only ActiveRecords, which
can be prevented by specifying :select.

-> see

Please merge this :)

jeffday commented Oct 17, 2013


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.