From abdb44d801c18bb015d7592a46e00408b20d0455 Mon Sep 17 00:00:00 2001 From: Sam Vevang Date: Mon, 29 Apr 2024 10:14:12 -0500 Subject: [PATCH] Remove the noImp decorator in enclosure builder --- app/models/apple/episode.rb | 1 - app/models/enclosure_url_builder.rb | 6 ------ test/models/apple/episode_test.rb | 4 ++-- test/models/enclosure_url_builder_test.rb | 10 ---------- 4 files changed, 2 insertions(+), 19 deletions(-) diff --git a/app/models/apple/episode.rb b/app/models/apple/episode.rb index 7325f63ad..04b8ffdf7 100644 --- a/app/models/apple/episode.rb +++ b/app/models/apple/episode.rb @@ -242,7 +242,6 @@ def podcast def enclosure_url url = EnclosureUrlBuilder.new.base_enclosure_url(podcast, feeder_episode, private_feed) - url = EnclosureUrlBuilder.mark_no_imp(url) EnclosureUrlBuilder.mark_authorized(url, show.private_feed) end diff --git a/app/models/enclosure_url_builder.rb b/app/models/enclosure_url_builder.rb index 88cb0c248..af8cfe056 100644 --- a/app/models/enclosure_url_builder.rb +++ b/app/models/enclosure_url_builder.rb @@ -17,12 +17,6 @@ def self.mark_authorized(enclosure_url, feed) add_query_param(enclosure_url, "auth", token) end - # Marks the url as a `noImp` - # Used by Dovetail to skip the impression tracking - def self.mark_no_imp(enclosure_url) - add_query_param(enclosure_url, "noImp", "1") - end - def podcast_episode_url(podcast, episode, feed = nil) feed ||= podcast.default_feed prefix = feed.try(:enclosure_prefix) diff --git a/test/models/apple/episode_test.rb b/test/models/apple/episode_test.rb index 6f0e52b9d..3b1b94ecb 100644 --- a/test/models/apple/episode_test.rb +++ b/test/models/apple/episode_test.rb @@ -62,8 +62,8 @@ end describe "#enclosure_url" do - it "should add a noImp query param" do - assert_match(/noImp=1/, apple_episode.enclosure_url) + it "should add auth query param" do + assert_match(/auth=/, apple_episode.enclosure_url) end end diff --git a/test/models/enclosure_url_builder_test.rb b/test/models/enclosure_url_builder_test.rb index fbcc9566a..a73b3d3dc 100644 --- a/test/models/enclosure_url_builder_test.rb +++ b/test/models/enclosure_url_builder_test.rb @@ -131,16 +131,6 @@ end describe "a set of class methods to mark (annotate) enclosure urls" do - describe ".mark_no_imp" do - it "should add a noImp query param" do - assert_equal "http://example.com?noImp=1", EnclosureUrlBuilder.mark_no_imp("http://example.com") - end - - it "should preserve existing query params" do - assert_equal "http://example.com?foo=bar&noImp=1", EnclosureUrlBuilder.mark_no_imp("http://example.com?foo=bar") - end - end - describe ".mark_authorized" do let(:private_feed) { create(:private_feed, podcast: podcast) } let(:feed_tok) { private_feed.tokens.first }