New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify package dependencies #18

Merged
merged 3 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@martinholmer
Copy link
Collaborator

martinholmer commented Nov 6, 2018

This pull request attempts to simplify the package dependencies contained in the environment.yml and conda.recipe/meta.yaml files. This simplification is made possible by the fact that the Behavioral-Responses behresp package does not depend on any packages other than those the Tax-Calculator taxcalc package depends on. This simplification works on my local computer and this pull request will see if it works on GitHub when the checkin tests are run.

The Travis tests on Linux ran successfully from the initial commit. However, the AppVeyor (continuous_integration) tests on Windows failed because, for some reason, it didn't have pytest installed. Commit 57086c2 fixed that problem and now the tests also run successfully under AppVeyor on Windows.

This demonstrates the ability to dramatically simplify the package dependencies of any PSL model that depends on the Tax-Calculator taxcalc package. Here is the environment.yml file checked-in as part of this Behavioral-Responses pull request:

name: behresp-dev
channels:
- OSPC
dependencies:
- python=3.6
- taxcalc

And here is the conda.recipe/meta.yaml file checked-in as part of this Behavioral-Responses pull request:

package:
  name: behresp
  version: 0.0.0

requirements:
  build:
    - python=3.6
    - taxcalc

  run:
    - python=3.6
    - taxcalc

test:
  imports:
    - behresp

about:
  home: https://github.com/open-source-economics/Behavioral-Response

Of course, if a Tax-Calculator-using PSL model depends on some package not used by Tax-Calculator, then that package would need to be added below the - taxcalc entries.

@MattHJensen @codykallen @jdebacker @rickecon @hdoupe @andersonfrailey

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 6, 2018

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         104    104           
=====================================
  Hits          104    104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb22cb...57086c2. Read the comment docs.

@martinholmer martinholmer merged commit 5e9cda9 into PSLmodels:master Nov 6, 2018

4 checks passed

codecov/patch Coverage not affected when comparing acb22cb...57086c2
Details
codecov/project 100% remains the same compared to acb22cb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martinholmer martinholmer deleted the martinholmer:0-3-0 branch Nov 6, 2018

@jdebacker jdebacker referenced this pull request Nov 12, 2018

Merged

Updates to meta.yaml #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment