New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic files and associated tests #3

Merged
merged 36 commits into from Oct 25, 2018

Conversation

Projects
None yet
3 participants
@martinholmer
Copy link
Collaborator

martinholmer commented Oct 17, 2018

This pull request begins adding very-preliminary logic/test files to the Behavioral-Response repository.

@martinholmer martinholmer added the WIP label Oct 19, 2018

@martinholmer martinholmer changed the title Add logic files Add logic files and associated tests Oct 19, 2018

@martinholmer martinholmer reopened this Oct 20, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 20, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@7c2e780). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #3   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      2           
  Lines             ?    104           
  Branches          ?      0           
=======================================
  Hits              ?    104           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
behresp/behavior.py 100% <100%> (ø)
behresp/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2e780...299177b. Read the comment docs.

@martinholmer martinholmer removed the WIP label Oct 24, 2018

@MattHJensen MattHJensen referenced this pull request Oct 25, 2018

Closed

Do not merge. #7

@MattHJensen

This comment has been minimized.

Copy link
Contributor

MattHJensen commented Oct 25, 2018

@martinholmer, how do you feel about the subsample solution to the failing Travis builds. According to Travis docs, the memory max is 3GB.

@martinholmer

This comment has been minimized.

Copy link
Collaborator Author

martinholmer commented Oct 25, 2018

@MattHJensen said:

How do you feel about the subsample solution to the failing Travis builds?
According to Travis docs, the memory max is 3GB.

Doing this in commit 299177b seemed to do the trick: the tests ran to completion (just like on my computer) and the code coverage was generated. So, everything seems to be working. Sorry about thinking the problem was with the GitHub setup but I couldn't figure out why the tests were running on AppVeyor (but not Travis).

I couldn't implement the subsampling approach in the Behavioral-Responses tests until I had finished making the conda packages for Tax-Calculator 0.22.1 this afternoon.

@martinholmer martinholmer merged commit 059efd2 into PSLmodels:master Oct 25, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martinholmer martinholmer deleted the martinholmer:add-logic branch Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment