Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify extraction of non-dump variables from Calculator objects in response function #62

merged 3 commits into from May 13, 2019


None yet
2 participants
Copy link

commented May 12, 2019

This simplification produces a minor speed up in the execution of the response function.
No change in behavioral logic or results.


This comment has been minimized.

Copy link

commented May 12, 2019

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #62   +/-   ##
  Coverage     100%   100%           
  Files           2      2           
  Lines         114    114           
  Hits          114    114
Impacted Files Coverage Δ
behresp/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e886865...c1145d1. Read the comment docs.

@martinholmer martinholmer added the ready label May 12, 2019

martinholmer added some commits May 13, 2019

@martinholmer martinholmer removed the ready label May 13, 2019

@martinholmer martinholmer merged commit bbac4c7 into PSLmodels:master May 13, 2019

3 checks passed

codecov/patch 100% of diff hit (target 100%)
codecov/project 100% (+0%) compared to e886865
continuous-integration/travis-ci/pr The Travis CI build passed

@martinholmer martinholmer deleted the martinholmer:dataframe branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.