Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfers #479

Merged
merged 19 commits into from Aug 15, 2019

Conversation

@jdebacker
Copy link
Contributor

commented Aug 12, 2019

This PR adds a matrix to allocate aggregate gov't transfers across households by age and lifetime income group, as suggested in Issue #467.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #479 into master will decrease coverage by 6.08%.
The diff coverage is 68.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   65.73%   59.65%   -6.09%     
==========================================
  Files          40       40              
  Lines        5242     5316      +74     
==========================================
- Hits         3446     3171     -275     
- Misses       1796     2145     +349
Impacted Files Coverage Δ
ogusa/tests/test_firm.py 100% <ø> (ø) ⬆️
ogusa/postprocess.py 40% <ø> (ø) ⬆️
ogusa/output_plots.py 7.97% <ø> (ø) ⬆️
ogusa/tests/test_aggregates.py 100% <ø> (ø) ⬆️
ogusa/tests/test_household.py 100% <100%> (ø) ⬆️
ogusa/tax.py 97.98% <100%> (-0.03%) ⬇️
ogusa/tests/test_fiscal.py 100% <100%> (ø) ⬆️
ogusa/household.py 86.13% <100%> (-0.7%) ⬇️
ogusa/tests/test_tax.py 100% <100%> (ø) ⬆️
ogusa/fiscal.py 100% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cfb624...f8459ce. Read the comment docs.

@jdebacker

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@rickecon This PR is ready for your review.

@rickecon rickecon referenced this pull request Aug 15, 2019
@jdebacker

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@rickecon This PR should be ready to go now. Thanks.

@rickecon

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@jdebacker I am just waiting for the CI tests to pass.

@rickecon rickecon merged commit a0f2313 into PSLmodels:master Aug 15, 2019

3 checks passed

codecov/patch 68.04% of diff hit (target 65.73%)
Details
codecov/project Absolute coverage decreased by -6.08% but relative coverage increased by +2.3% compared to 6cfb624
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rickecon rickecon referenced this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.