Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output table #483

Merged
merged 13 commits into from Aug 19, 2019

Conversation

@jdebacker
Copy link
Contributor

commented Aug 18, 2019

This PR adds a function to produce a table of macro output. In addition, updates are made to parameter and output plotting functions.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 18, 2019

Codecov Report

Merging #483 into master will increase coverage by 3.32%.
The diff coverage is 69.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   59.65%   62.97%   +3.32%     
==========================================
  Files          40       45       +5     
  Lines        5316     5470     +154     
==========================================
+ Hits         3171     3445     +274     
+ Misses       2145     2025     -120
Impacted Files Coverage Δ
ogusa/tests/test_SS.py 83.03% <ø> (-0.07%) ⬇️
ogusa/tests/test_output_tables.py 100% <100%> (ø)
ogusa/constants.py 100% <100%> (ø) ⬆️
ogusa/tests/test_parameter_plots.py 100% <100%> (ø)
ogusa/tests/test_parameter_tables.py 100% <100%> (ø)
ogusa/tests/test_output_plots.py 100% <100%> (ø)
ogusa/output_plots.py 55.49% <22.72%> (+47.51%) ⬆️
ogusa/output_tables.py 55.22% <55.22%> (ø)
ogusa/parameter_plots.py 78.12% <66.66%> (+66.29%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba038d...b1bfff3. Read the comment docs.

@rickecon

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@jdebacker Is this ready to be merged? It looks good to me.

@jdebacker

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@rickecon - yes this is ready to go. Thanks.

@rickecon rickecon merged commit 5d46c1c into PSLmodels:master Aug 19, 2019

3 checks passed

codecov/patch 69.56% of diff hit (target 59.65%)
Details
codecov/project 62.97% (+3.32%) compared to 2ba038d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.