Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TBI to work with new COMP requirements #38

Merged
merged 7 commits into from May 6, 2019

Conversation

Projects
None yet
2 participants
@andersonfrailey
Copy link
Collaborator

commented Apr 24, 2019

This PR is meant to bring Tax-Brain's TBI output inline with COMP's new output format. Right now, the TBI returns a dictionary full of tables and tags that COMP then processes. Now it will return a dictionary with a Bokeh layout that contains all of those outputs.

cc @hdoupe

@hdoupe

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Looks good @andersonfrailey. I'm working on some preliminary automated testing for the inputs and outputs formats. If you're willing to be a guinea pig, we can try that out on the new outputs before you do a release.

@andersonfrailey

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 24, 2019

@hdoupe always down to guinea pig COMP. Let me know what needs to be done on my end.

@hdoupe

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Awesome, thanks. I'll have something for you tomorrow.

@andersonfrailey

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2019

Latest commits add a compconfig directory. This will replace the TBI as the interface between COMP and Tax-Brain. All of the functions in the TBI have been moved to this directory. Additionally, the functions to get the default values, validate user input, and run the model have been changed to work with the new COMP workflow. See compconfig/compconfig/functions.py for details.

A later commit will remove the TBI from the repository.

cc @hdoupe

@andersonfrailey

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2019

Latest commit removes all of the TBI files. I've also updated the tests to work with Tax-Calculator 2.0.0.

@andersonfrailey andersonfrailey merged commit ede7626 into PSLmodels:master May 6, 2019

@andersonfrailey andersonfrailey deleted the andersonfrailey:compupdates branch May 6, 2019

@andersonfrailey andersonfrailey added the comp label May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.