Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Education Credit HC #1252

Merged
merged 1 commit into from Mar 20, 2017
Merged

Conversation

andersonfrailey
Copy link
Collaborator

This PR is a continuation of PR #1247 and adds a haircut for education credits. The reason it was not included in #1247 is at the time I was under the impression that education credits could be zeroed out by simply setting LLC_Expense and ETC_pe_Single/Married to zero, but that is not the case.

cc: @MattHJensen @martinholmer

@codecov-io
Copy link

Codecov Report

Merging #1252 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          38       38           
  Lines        2706     2706           
=======================================
  Hits         2697     2697           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4076f70...0b7abae. Read the comment docs.

@martinholmer
Copy link
Collaborator

@andersonfrailey, Thanks for adding an the additional haircut policy parameter in #1252. Looks good, so I'm merging it now.

@martinholmer martinholmer merged commit 9611e28 into PSLmodels:master Mar 20, 2017
This was referenced Mar 20, 2017
@andersonfrailey andersonfrailey deleted the educationhc branch July 20, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants