Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the EITC_indiv parameter #2254

Merged
merged 8 commits into from Mar 16, 2019

Conversation

Projects
None yet
2 participants
@MattHJensen
Copy link
Contributor

commented Mar 8, 2019

Resolves #2199 in the following way:

This PR simplifies the _EITC_indiv parameter by narrowing its scope.

After these commits, turning on _EITC_indiv means that, for tax units filing jointly, the EITC is calculated for each spouse based on individual earnings.

Previously, the _EITC_indiv had this effect and also changed the investment income eligibility rules, changed the married filing jointly phaseout bonus (without actually changing the married filing jointly phaseout bonus parameter values), and changed the age eligibility rules.

This PR adds a new parameter that turns on and off whether the EITC can be claimed by tax units that are married filing separately, _EITC_sep_filers_elig. Under current law, _EITC_sep_filers_elig is false. I expect that many users of _EITC_indiv will want _EITC_sep_filers_elig to be true.

@martinholmer, could you please look this over?

@MattHJensen MattHJensen referenced this pull request Mar 8, 2019

Merged

reform test EITC_indiv #2253

matthjensen matthjensen
@codecov

This comment has been minimized.

Copy link

commented Mar 8, 2019

Codecov Report

Merging #2254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2254   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2983    2983           
======================================
  Hits         2983    2983

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc88c7...72dcb80. Read the comment docs.

@martinholmer

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@MattHJensen, Please don't include the changes to the docs/index.html file in this pull request.
We make those changes only with each release. If you were to include this file in PR #2254, the documentation for the current release of Tax-Calculator would be wrong as soon as PR #2254 was merged.

I'll look at the substance of the proposed changes after you fix this problem.

@martinholmer

This comment has been minimized.

Copy link
Collaborator

commented Mar 10, 2019

@MattHJensen, You need to add some motivation and clarification for this PR. For example, why does adding a new policy parameter "simplify the EITC_indiv parameter"?

matthjensen matthjensen
@MattHJensen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

@martinholmer said:

Please don't include the changes to the docs/index.html file in this pull request.
We make those changes only with each release. If you were to include this file in PR #2254, the documentation for the current release of Tax-Calculator would be wrong as soon as PR #2254 was merged.

The latest commit resets docs/index.html to master. (Thanks to this stack overflow thread)

You need to add some motivation and clarification for this PR.

Good point. This PR simplifies the EITC_indiv parameter by narrowing its scope.

After these commits, turning on EITC_indiv means that, for tax units filing jointly, the EITC is calculated for each spouse based on individual earnings.

Previously, the EITC_indiv had this effect and also changed the investment income eligibility rules, changed the married filing jointly phaseout bonus (without actually changing the married filing jointly phaseout bonus parameter values), and changed the age eligibility rules.

This PR adds a new parameter that turns on and off whether the EITC can be claimed by tax units that are married filing separately, EITC_sep_filers_elig. Under current law, EITC_sep_filers_elig is false. I expect that many users of EITC_indiv will want EITC_sep_filers_elig to be true.

@martinholmer

This comment has been minimized.

Copy link
Collaborator

commented Mar 16, 2019

@MattHJensen, Thanks for the big improvements in structural EITC reform logic in pull request #2254.

@martinholmer martinholmer merged commit 13c9f22 into PSLmodels:master Mar 16, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 0dc88c7...72dcb80
Details
codecov/project 100% remains the same compared to 0dc88c7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MattHJensen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

Thanks for the discussion and review @martinholmer!

@MattHJensen MattHJensen deleted the MattHJensen:iEITC branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.