Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle larger integer parameter values #2269

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
1 participant
@martinholmer
Copy link
Collaborator

commented Mar 22, 2019

This pull request simply increases the size of each element in integer arrays holding parameters from np.int8 to np.int16.

@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #2269 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2269   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2997    2997           
======================================
  Hits         2997    2997
Impacted Files Coverage Δ
taxcalc/parameters.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ede080...49b9682. Read the comment docs.

@martinholmer martinholmer merged commit c35f405 into PSLmodels:master Mar 22, 2019

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 1ede080
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.