Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validation/taxsim/ logic to reflect new TAXSIM-27 logic #2278

merged 2 commits into from Mar 30, 2019


None yet
1 participant
Copy link

commented Mar 29, 2019

Recently detailed output for variable 22 produced by TAXSIM-27 was changed. Formerly output variable 22 included only the non-refundable child tax credit, but now for years 2018+ it includes the sum of the non-refundable child tax credit and the non-refundable other dependent tax credit (which was introduced beginning in 2018 by the TCJA reform). Besides uploading the a18, b18, and c18 samples to get new TAXSIM-27 results, one line in the taxcalc/validation/taxsim/ file was changed to translate Tax-Calculator results into TAXSIM-style results.


This comment has been minimized.

Copy link

commented Mar 29, 2019

Codecov Report

Merging #2278 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2278   +/-   ##
  Coverage     100%    100%           
  Files          12      12           
  Lines        2997    2997           
  Hits         2997    2997

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f7a54...2f0e55e. Read the comment docs.

@martinholmer martinholmer merged commit d7587d8 into PSLmodels:master Mar 30, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 81f7a54...2f0e55e
codecov/project 100% remains the same compared to 81f7a54
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@martinholmer martinholmer deleted the martinholmer:fix-taxsim-ctc branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.