Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Redefining Expanded Income" cookbook recipe #2321

Merged
merged 9 commits into from May 20, 2019

Conversation

Projects
None yet
1 participant
@martinholmer
Copy link
Collaborator

commented May 11, 2019

This recipe introduces a powerful technique for customizing the operation of Tax-Calculator. This calculator-customization technique is used in the new recipe 5 to redefine expanded_income in a way that allows the redefined income measure to be used seamlessly with all the other (table and graph) methods of the Calculator class. The basic idea behind the calculator-customization technique is to derive a customized Calculator class from the Tax-Calculator Calculator class. This is a standard object-oriented programming technique.

Adding this recipe resolves issue #2309.

@codecov

This comment has been minimized.

Copy link

commented May 11, 2019

Codecov Report

Merging #2321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2321   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2784    2784           
======================================
  Hits         2784    2784

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d8867...bf8e200. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented May 11, 2019

Codecov Report

Merging #2321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2321   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2703    2703           
======================================
  Hits         2703    2703

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe6cef...835fc1c. Read the comment docs.

@martinholmer martinholmer added WIP and removed WIP labels May 19, 2019

@martinholmer martinholmer merged commit bffbde1 into PSLmodels:master May 20, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 2fe6cef...835fc1c
Details
codecov/project 100% remains the same compared to 2fe6cef
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martinholmer martinholmer deleted the martinholmer:recipe5 branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.