Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Records class logic #2337

Merged
merged 15 commits into from Jun 8, 2019

Conversation

Projects
None yet
1 participant
@martinholmer
Copy link
Collaborator

commented Jun 7, 2019

This pull request separates the logic in the old Records class into two parts: the generic code involved in handling data observations that are aged each year and code that is specific to the Tax-Calculator model. The generic code is now in a new abstract base class called Data with code in the taxcalc/data.py file and tests in the taxcalc/tests/test_data.py file. The Tax-Calculator-specific code is in the revised Records class, which is now derived from the Data class (in the same way as the Policy class is derived from the Parameters class).

There should be no effect on models that use the high-level Records capabilities of Tax-Calculator because those high-level capabilities have not changed.

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #2337 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2337   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      13    +1     
  Lines        2713    2741   +28     
======================================
+ Hits         2713    2741   +28
Impacted Files Coverage Δ
taxcalc/parameters.py 100% <ø> (ø) ⬆️
taxcalc/taxcalcio.py 100% <100%> (ø) ⬆️
taxcalc/growfactors.py 100% <100%> (ø) ⬆️
taxcalc/data.py 100% <100%> (ø)
taxcalc/__init__.py 100% <100%> (ø) ⬆️
taxcalc/records.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2336494...2ff2081. Read the comment docs.

@martinholmer martinholmer merged commit 9e66030 into PSLmodels:master Jun 8, 2019

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 2336494
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martinholmer martinholmer deleted the martinholmer:redo-recs branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.