From efdbaf0b5a0848be362e1807d8d5cfbb2be3348c Mon Sep 17 00:00:00 2001 From: Sri Lasya Date: Tue, 3 Mar 2026 18:37:53 +0530 Subject: [PATCH] Fix: Added null safrty check in NHM dashboard scheduler to prevent startup NullPointerException(#121) --- pom.xml | 5 ++- .../ScheduleJobForNHMDashboardData.java | 31 ++++++++++++------- 2 files changed, 23 insertions(+), 13 deletions(-) diff --git a/pom.xml b/pom.xml index f0badf34..9d64fecf 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ {hostname-${environment}} {port-${environment}} - + openkm.com @@ -53,6 +53,7 @@ https://maven.openkm.com + @@ -204,6 +205,7 @@ com.fasterxml.jackson.core jackson-annotations 2.17.0 + com.fasterxml.jackson.core @@ -211,6 +213,7 @@ 2.17.0 + com.openkm sdk4j 1.0 diff --git a/src/main/java/com/iemr/common/config/quartz/ScheduleJobForNHMDashboardData.java b/src/main/java/com/iemr/common/config/quartz/ScheduleJobForNHMDashboardData.java index c9b29c62..4fde5534 100644 --- a/src/main/java/com/iemr/common/config/quartz/ScheduleJobForNHMDashboardData.java +++ b/src/main/java/com/iemr/common/config/quartz/ScheduleJobForNHMDashboardData.java @@ -42,15 +42,22 @@ public class ScheduleJobForNHMDashboardData implements Job { @Autowired private NHM_DashboardService nhmDashboardService; - @Override - public void execute(JobExecutionContext arg0) throws JobExecutionException { - logger.info("Started job for NHM dashboard data pull from cti " + arg0.getClass().getName()); - try { - String s = nhmDashboardService.pull_NHM_Data_CTI(); - logger.info(s); - } catch (Exception e) { - logger.error(e.getLocalizedMessage()); - } - logger.info("Completed job for NHM dashboard data pull from cti " + arg0.getClass().getName()); - } -} + @Override +public void execute(JobExecutionContext arg0) throws JobExecutionException { + + logger.info("Started job for NHM dashboard data pull from cti " + arg0.getClass().getName()); + + if (nhmDashboardService == null) { + logger.error("NHM_DashboardService bean is not initialized. Skipping execution."); + return; + } + + try { + String s = nhmDashboardService.pull_NHM_Data_CTI(); + logger.info(s); + } catch (Exception e) { + logger.error("Error while pulling NHM dashboard data", e); + } + + logger.info("Completed job for NHM dashboard data pull from cti " + arg0.getClass().getName()); +} \ No newline at end of file