Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force UIModalPresentationFullScreen for the native module on iOS 13 #307

Merged
merged 3 commits into from Oct 3, 2019
Merged

Force UIModalPresentationFullScreen for the native module on iOS 13 #307

merged 3 commits into from Oct 3, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Oct 2, 2019 •
edited

Details

How to Reproduce:

Use the native module to present a document (PSPDFKit.present()) on iOS 13.

Before After
Screen Shot 2019-10-02 at 11 58 55 AM Screen Shot 2019-10-02 at 12 01 17 PM

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz requested a review from steviki October 2, 2019 16:06
@radazzouz radazzouz self-assigned this Oct 2, 2019
steipete
steipete approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@douglashill
Copy link

What’s the reason for using over full screen rather than full screen? Our view is opaque as far as I know, and regular full screen is likely to keep memory use a little bit lower.

steviki
steviki approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ios/RCTPSPDFKit/RCTPSPDFKitManager.m Outdated Show resolved Hide resolved
radazzouz and others added 2 commits October 3, 2019 07:58
@radazzouz @steviki
Update ios/RCTPSPDFKit/RCTPSPDFKitManager.m
e33beb9 
Co-Authored-By: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Bump version to 1.26.1
0b7e324
@radazzouz radazzouz merged commit 6d26969 into master Oct 3, 2019
@radazzouz radazzouz deleted the rad/modal-presentation-style-ios-13 branch October 3, 2019 12:02
@radazzouz radazzouz changed the title Force UIModalPresentationOverFullScreen for the native module on iOS 13 Force UIModalPresentationFullScreen for the native module on iOS 13 Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete steipete approved these changes

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
4 participants
@radazzouz @douglashill @steipete @steviki