Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameInfo builder #99

merged 2 commits into from
Apr 6, 2023


Copy link

This adds in fluent API style contruction for FrameInfo. Now you can do

let info = FrameInfo::new()

IMO it reads better, but it also has the benefit of making it easier to see when the returned FrameInfo is unused through avoiding mutability. E.g this wouldn't get picked up as unused

let mut info = FrameInfo::new();
info.content_checksum = true;

Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #99 (a8baba2) into main (be2ea76) will decrease coverage by 0.99%.
The diff coverage is 11.53%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
- Coverage   89.39%   88.41%   -0.99%     
  Files          11       11              
  Lines        2179     2192      +13     
- Hits         1948     1938      -10     
- Misses        231      254      +23     
Impacted Files Coverage Δ
src/frame/ 79.74% <11.53%> (-9.10%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit 0293879 into PSeitz:main Apr 6, 2023
2 of 4 checks passed
Copy link

PSeitz commented Apr 6, 2023


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants