Don't test the protected/private method

[agiuliano]

As Sebastian himself says, the private methods have to be tested indirectly

[odino]

even the protected ones ;)

[liuggio]

great, but what's the task to be done?

[agiuliano]

the createImage function for example has to be tested indirectly by testing all the public function that use it and passing them a plenty of input that test the correct work of createImage too

@odino yep, I mean protected and private ;)

[leopro]

@agiuliano imho a comment directly on code is better ;-)

[agiuliano]

@leopro you're right!

[liuggio]

Could we close this?

[agiuliano]

I think not, 'cause of https://github.com/PUGX/badge-poser/blob/master/src/PUGX/BadgeBundle/Tests/Service/ImageCreatorTest.php#L90

[liuggio]

fair enough...
there's another smell on tests: use PUGX\StatsBundle\Test\StatsFunctionalTest; on https://github.com/PUGX/badge-poser/blob/master/src/PUGX/BadgeBundle/Tests/Controller/PageControllerTest.php
we have coupled those bundles... maybe we could clean it.

[liuggio]

I have decoupled those tests #84

still as @agiuliano said some cleaning are needed

[cirpo]

@agiuliano such as? I would love to work on this :)

[liuggio]

@cirpo we would love you

[JellyBellyDev]

I believe that this issue can be closed. thank you!