Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show in homepage the counter of total badges rendered #87

Closed
liuggio opened this issue Nov 8, 2013 · 5 comments
Closed

show in homepage the counter of total badges rendered #87

liuggio opened this issue Nov 8, 2013 · 5 comments

Comments

@liuggio
Copy link
Member

liuggio commented Nov 8, 2013

show in homepage the number of total badges rendered

could be great having on top pull-left a counter that show the current number of total badges rendered, in redis is STAT.TOTAL

  • Optional the number increase automatically (is possible without ajax?).
@hpatoio
Copy link
Contributor

hpatoio commented Nov 15, 2013

Hello.

I'm thinking about closing this issue. Just tell me if these steps are correct.

  • add a method "getTotalAccess" to PersisterInterface and all the class that implements it that returns the key STAT.TOTAL
  • Modify homeAction in PageController to read the total count and pass it to the view

I can later implement the live count. But let's start with this easy version

@liuggio
Copy link
Member Author

liuggio commented Nov 15, 2013

Hi that's great,
yes this could be a good way,

but PersisterInterface is used now to Persist and only store data as RedisPersister does.
What do you think to create another interface and another service only to handle and manage statistic?
This could introduce a little bit of overhead but at least we could split the concern.

About the modification yes this is a good way,
I was thinking about a new Controller in StatsBundle that serve only the number, and use render in /src/PUGX/BadgeBundle/Resources/views/Page/home.html.twig...
But I'd go for your idea is simpler and maybe cleaner 💃

YEAAA

@hpatoio
Copy link
Contributor

hpatoio commented Nov 15, 2013

I was also thinking about create a new interface/service to read stats. So, ok for me. Hope to send my PR soon.
Ciao

@liuggio
Copy link
Member Author

liuggio commented Nov 15, 2013

👯

liuggio added a commit that referenced this issue Nov 21, 2013
@liuggio
Copy link
Member Author

liuggio commented Nov 21, 2013

closed by #90

@liuggio liuggio closed this as completed Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants