New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavlink: fixed nullptr dereferencing #10063

Merged
merged 1 commit into from Jul 27, 2018

Conversation

Projects
None yet
3 participants
@RomanBapst
Copy link
Contributor

RomanBapst commented Jul 27, 2018

Thanks to @bkueng for helping find this.

@LorenzMeier @dagar Do we need to back-port this?

mavlink: fixed nullptr dereferencing in case unknown mavlink message is
forwarded

Signed-off-by: Roman <bapstroman@gmail.com>
@RomanBapst

This comment has been minimized.

Copy link
Contributor Author

RomanBapst commented Jul 27, 2018

We suppose that in our case this happened because we had a companion computer communication to the FC via mavlink and was using a newer mavlink version. On Monday we can verify that this in indeed the problem.

@dagar

This comment has been minimized.

Copy link
Member

dagar commented Jul 27, 2018

We could do a v1.8.1 release with this and a couple other little bug fixes cherry-picked.

int target_system_id = (meta->target_system_ofs != 0) ? ((uint8_t *)msg)[meta->target_system_ofs] : 0;
int target_component_id = (meta->target_component_ofs != 0) ? ((uint8_t *)msg)[meta->target_component_ofs] : 233;
int target_system_id = 0;
int target_component_id = 233;

This comment has been minimized.

@dagar

dagar Jul 27, 2018

Member

233?

@dagar dagar added this to the Release v1.8.1 milestone Jul 27, 2018

@dagar dagar added the bug label Jul 27, 2018

@dagar dagar requested a review from bkueng Jul 27, 2018

@dagar dagar referenced this pull request Jul 27, 2018

Closed

PX4 Stable v1.8.1 Planning #10064

@bkueng

bkueng approved these changes Jul 27, 2018

Copy link
Member

bkueng left a comment

Yes we should cherry-pick this to stable.

@bkueng bkueng merged commit 37f59ad into master Jul 27, 2018

4 checks passed

WIP ready for review
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/branch This commit looks good
Details

@bkueng bkueng deleted the pr-mavlink_fix branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment