New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc_att_control: copy sensor_correction topic once initially #10830

Closed
wants to merge 1 commit into
base: stable
from

Conversation

Projects
None yet
2 participants
@RomanBapst
Copy link
Contributor

RomanBapst commented Nov 12, 2018

This was causing the mc_att_controller and the sensors module not to be in sync after a reboot regarding which instance of the gyro topic was selected.
This is relevant when using the CAL_GYROx_EN parameters to disable a specific IMU.

mc_att_control: copy sensor_correction topic once initially
Signed-off-by: Roman <bapstroman@gmail.com>
@dagar

This comment has been minimized.

Copy link
Member

dagar commented Nov 12, 2018

We need to be more deliberate when putting things directly into stable. If the tag isn't also updated then QGC users will get a bogus dev version as well as warnings.

@dagar dagar self-requested a review Nov 12, 2018

@RomanBapst

This comment has been minimized.

Copy link
Contributor Author

RomanBapst commented Nov 12, 2018

@dagar against what do you want me to do this PR? Also do you know why CI is failing? I can't get rid of the 404.

@dagar

This comment has been minimized.

Copy link
Member

dagar commented Nov 12, 2018

Can you fix it in master first, then backport it to stable? We need to tag it at the same time it goes into the stable branch.

@RomanBapst

This comment has been minimized.

Copy link
Contributor Author

RomanBapst commented Nov 12, 2018

@dagar according to @bkueng this should already be fixed in master due to a change in uorb behavior, see my comment in the code.

@dagar

This comment has been minimized.

Copy link
Member

dagar commented Nov 12, 2018

Right okay. 2fe5e77#diff-14d11b3fe5440be3f4a64b36f55287ad

Then let's get this into stable and tag it v1.8.2

@dagar

This comment has been minimized.

Copy link
Member

dagar commented Nov 13, 2018

@dagar dagar closed this Nov 13, 2018

@dagar dagar deleted the pr-mc_att branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment