Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Wlogical-op, cleanup platform compiler flags, and fix missing initializers #7346

Closed
wants to merge 29 commits into from

Conversation

Projects
None yet
6 participants
@dagar
Copy link
Member

dagar commented Jun 3, 2017

No description provided.

@dagar dagar force-pushed the dagar:wlogical branch 6 times, most recently Jun 3, 2017

src/drivers/bmi160/bmi160.cpp Outdated
@@ -1290,7 +1290,7 @@ BMI160::measure()
grb.temperature = _last_temperature;

/* return device ID */
grb.device_id = _gyro->_device_id.devid;
grb.device_id = _gyro->_device_id.devid;;

This comment has been minimized.

Copy link
@LorenzMeier

LorenzMeier Jun 4, 2017

Member

This looks wrong.

@LorenzMeier

This comment has been minimized.

Copy link
Member

LorenzMeier commented Jun 4, 2017

@bkueng Can you test on RPI? @ChristophTobler Can you test on Snapdragon? @PX4TestFlights Can you please test on all airframes?

@dagar dagar force-pushed the dagar:wlogical branch 5 times, most recently Jun 4, 2017

@dagar dagar referenced this pull request Jun 5, 2017

Closed

enable sign-compare warning #7148

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Jun 5, 2017

Added sign-compare checks (#7148) to simplify testing.

@santiago3dr

This comment has been minimized.

Copy link

santiago3dr commented Jun 5, 2017

@ChristophTobler

This comment has been minimized.

Copy link
Member

ChristophTobler commented Jun 6, 2017

build and upload worked, but I didn't test it because of #7362

src/systemcmds/tests/test_param.c Outdated
@@ -49,7 +49,6 @@
/**

This comment has been minimized.

Copy link
@bkueng

bkueng Jun 6, 2017

Member

This comment can be removed as well

@bkueng

This comment has been minimized.

Copy link
Member

bkueng commented Jun 7, 2017

Bench tested on RPi, works

@dagar dagar force-pushed the dagar:wlogical branch Jun 20, 2017

dagar added some commits Jun 3, 2017

dagar added some commits Apr 28, 2017

@LorenzMeier

This comment has been minimized.

Copy link
Member

LorenzMeier commented Aug 1, 2017

@dagar Looks like we missed to merge in time, sorry! Would you mind rebasing?

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Aug 1, 2017

No problem, sprawling PRs are probably a bad idea.

I'll split this up into a few different PRs.

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Sep 16, 2017

Largely replaced by #7973, #7974, #7975, #7976

@dagar dagar closed this Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.