RTPS and micro-CDR build system improvements #8084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-cmake_rtps_cdr
branch
4 times, most recently
from
3dc5ffe
to
b20cc9d
Compare
bkueng
previously approved these changes
Oct 9, 2017
msg/CMakeLists.txt
Outdated
| set(send_topic_files) | ||
| foreach(topic ${config_rtps_send_topics}) | ||
| list(APPEND send_topic_files ${PX4_SOURCE_DIR}/msg/${topic}.msg) | ||
| endforeach() |
There was a problem hiding this comment.
Merge this loop with the next one?
| @@ -0,0 +1,221 @@ | |||
| @############################################### | |||
There was a problem hiding this comment.
is msg/templates/uorb/microRTPS_client.cpp.template still needed?
dagar
force-pushed
the
pr-cmake_rtps_cdr
branch
from
b20cc9d
to
344c200
Compare
bkueng
reviewed
Oct 11, 2017
msg/CMakeLists.txt
Outdated
| set(msg_file ${PX4_SOURCE_DIR}/msg/${topic}.msg) | ||
| list(APPEND send_topic_files ${msg_file}) | ||
| get_filename_component(msg ${msg_file} NAME_WE) | ||
| list(APPEND uorb_headers_microcdr ${msg_out_path_microcdr}/${msg}.h) |
There was a problem hiding this comment.
Isn't ${msg} just the same as ${topic}?
dagar
force-pushed
the
pr-cmake_rtps_cdr
branch
from
344c200
to
0411a32
Compare
dagar
force-pushed
the
pr-cmake_rtps_cdr
branch
from
0411a32
to
8f75143
Compare
bkueng
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some build system issues with RTPS and microCDR.
@mcharleb @bkueng any issues with doing this? It improves build times and doesn't burden targets like the px4io with generating and building all this stuff the linker just throws away.
I still don't like the way this quietly depends on fastrtpsgen being found. It creates a situation where users can build and test locally, but break once pushed to CI. If fastrtpsgen isn't yet a hard requirement we should leave it out of the default builds and have rtps configurations where not being able to find fastrtpsgen is a fatal error (nuttx_px4fmu-v4_rtps, posix_sitl_rtps, etc)
This has been split out of #8043.