Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move RTPS to dedicated px4fmu-v{3,4,4pro,5}, posix, sdflight builds #8113

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
4 participants
@dagar
Copy link
Member

dagar commented Oct 11, 2017

RTPS and micro-cdr now only included and required in the following builds

- nuttx_px4fmu-v3_rtps
- nuttx_px4fmu-v4_rtps
- nuttx_px4fmu-v4pro_rtps
- nuttx_px4fmu-v5_rtps

- posix_sitl_rtps

- posix_eagle_rtps
- posix_excelsior_rtps

@dagar dagar requested review from mcharleb, davids5 and bkueng Oct 11, 2017

@davids5
Copy link
Member

davids5 left a comment

@dagar - This looks good. Is the CI failure real?

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Oct 11, 2017

No, that's been failing intermittently.

@bkueng
Copy link
Member

bkueng left a comment

This looks good

lib/micro-CDR
)

set(config_rtps_send_topics

This comment has been minimized.

Copy link
@bkueng

bkueng Oct 12, 2017

Member

Can we move the set of topics to common/rtps? Will be easier to manage.

This comment has been minimized.

Copy link
@dagar

dagar Oct 12, 2017

Author Member

That sounds fine to me, but I don't think we know how this is actually intended to be used.

@@ -209,6 +213,14 @@ alt_firmware: \
check_s2740vc-v1_default \
sizes

# builds with RTPS
check_rtps: \

This comment has been minimized.

Copy link
@bkueng

bkueng Oct 12, 2017

Member

Is the plan to add this to CI? If so, we'll need to check the overhead of building all targets.

This comment has been minimized.

Copy link
@dagar

dagar Oct 12, 2017

Author Member

Yes, this is for CI.

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Oct 17, 2017

Apologies for continuing to change this, but what do you think about everything living within modules/micrortps_bridge? micro-CDR, generation, topic lists, etc

Little things like this will help as we work towards large restructuring for modularity (#8127, #8139).

See updated push.

@dagar dagar dismissed stale reviews from bkueng and davids5 via 6557cd8 Oct 17, 2017

@dagar dagar force-pushed the dagar:pr-rtps_builds branch from a242a3d to 6557cd8 Oct 17, 2017

@mcharleb

This comment has been minimized.

Copy link
Contributor

mcharleb commented Oct 17, 2017

Looks good. I'd still like to be able to use the generated agent code without having to sync and build PX4 to get it.

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Oct 17, 2017

We could have Firmware output a library (with a cmake build system) that's automatically pushed to another github repo. That generated library could be versioned to match Firmware.

@dagar

This comment has been minimized.

Copy link
Member Author

dagar commented Oct 17, 2017

Merging now to get it added to semaphoreci. I suspect this will go through a few more iterations once we figure out what to do with the generated agent code and the directory structure refactor.

@dagar dagar merged commit d83073f into PX4:master Oct 17, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 20.39% (target 10%)
Details
continuous-integration/sitl/pr Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@dagar dagar deleted the dagar:pr-rtps_builds branch Oct 17, 2017

jingego added a commit to jingego/JING_Firmware that referenced this pull request Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.