RTL check alt_max before using #8272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaEtUgR
reviewed
Nov 13, 2017
src/modules/navigator/rtl.cpp
Outdated
|
|
||
| static constexpr float DELAY_SIGMA = 0.01f; | ||
| using math::max; |
There was a problem hiding this comment.
probably you can't take away #include <mathlib/mathlib.h> and use the function defined in it...
or is it still in the include chain?
dagar
force-pushed
the
pr-rtl_min_alt
branch
3 times, most recently
from
d60edd7
to
a9ed78e
Compare
|
In a quick test the climb issue and multiple RTL in the same flight strangeness seem to be resolved, but there are many edge cases - https://logs.px4.io/plot_app?log=49ec4967-a06d-4115-8470-02287cd2c01e |
|
it looks ok, but the get_rtl_function is not really needed anymore. The point is that the altitude limit with -1 was introduced, but rtl pr was never merged, which resulted in a conflict. |
dagar
force-pushed
the
pr-rtl_min_alt
branch
from
a9ed78e
to
9b37d1e
Compare
|
Updated to remove get_rtl_altitude(). |
dagar
force-pushed
the
pr-rtl_min_alt
branch
from
9b37d1e
to
36f4717
Compare
Stifael
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #8257.