Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support large number of vehicles in multivehicle SITL #14126

Merged
merged 3 commits into from Feb 18, 2020

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Feb 9, 2020

Describe problem solved by this pull request
Previously, the number of vehicles that were able to be simulated was limited to 10 vehicles. This was due to a overlap on port numbering that overlapped in the rcS definition.

Describe your solution
Redefine gcs udp port from 14570 to 18570 in rcS.

Test data / coverage
Tested up to 100 instances of vehicles on a desktop.
Image below shows 30 vehicles

Screenshot from 2020-02-09 12-37-21

@Jaeyoung-Lim Jaeyoung-Lim changed the title Fix gcs udp port to support more vehicles in multivehicle sitl Support large number of vehicles in multivehicle SITL Feb 9, 2020
@Jaeyoung-Lim Jaeyoung-Lim requested review from julianoes and bkueng Feb 9, 2020
ROMFS/px4fmu_common/init.d-posix/rcS Outdated Show resolved Hide resolved
bkueng
bkueng approved these changes Feb 18, 2020
Copy link
Member

@bkueng bkueng left a comment

@bkueng bkueng merged commit 30cc3a1 into master Feb 18, 2020
44 of 47 checks passed
@bkueng bkueng deleted the pr-large-multivehicle-upstream branch Feb 18, 2020
jkflying pushed a commit that referenced this issue Feb 18, 2020
Reverts #14126 and #14176 until CI failures can be resolved
@dagar
Copy link
Member

dagar commented Feb 18, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants