- Initial support to comps xml parsing. Enable hif backend to search

[heliocastro]

categories and do a simple category mapping.
TODO:

• Add dynamic categories
• Replace package query function to a proper libhif function

Signed-off-by: Helio Chissini de Castro helio@kde.org

[kkofler]

@heliocastro: You still haven't addressed all of @hughsie's review comments, see my comments above.

[kkofler]

I still count 5 open issues, can you please have another look?

[kkofler]

I still count 4 open issues (you fixed 1 issue completely and 1 only partially), can you please have another look?

[kkofler]

@hughsie: The issues you pointed out should be addressed now, can this please be merged now?

[kkofler]

@hughsie: Ping?

[hughsie]

I'm going to review this after the next release; the current list of changes in the release is already too high, and I need to get an easy-to-QA release out to fix some libhif issues. I'll aim to review/merge this again next week.

[kkofler]

@hughsie: Re-ping? Almost 4 weeks have passed.

[kkofler]

@heliocastro: I just wanted to do a test build with your latest patchset, but it does not compile!

pk-backend-hif.c: In function 'pk_backend_get_groups_from_category':
pk-backend-hif.c:1285:12: error: 'groups' undeclared (first use in this function)
     return groups;
            ^
pk-backend-hif.c:1285:12: note: each undeclared identifier is reported only once for each function it appears in

Haven't you tested this? We need to make sure this 1. compiles and 2. actually works in Apper.

[kkofler]

@hughsie: The compilation error should be fixed with the above commit (from February 18) (it was a mistake in one of the requested cleanups), now can you PLEASE merge this? Over 3 weeks passed again.

This feature is very important to us Fedora KDE developers, and yet we have been waiting for it for almost a year now, and this pull request has been open for over 3 months.

[hughsie]

@heliocastro Can you merge all your patches down into one patch please, and then I can review it again. There are a few little issue, but I can't tell what was fixed in the subsequent patches.

@kkofler I'll merge it when it's ready.

[kkofler]

@hughsie: OK, I'll prepare a squashed commit, I think it'll be easier for everyone that way. (Helio does not want to work on this anymore, and I don't want to block on him again. We lost way too much time already.)

[kkofler]

Superseded by pull request #49.