Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo] add cxx mobilenetv1-ssd detection demo, test=develop #2541

Merged
merged 6 commits into from
Dec 3, 2019
Merged

[Demo] add cxx mobilenetv1-ssd detection demo, test=develop #2541

merged 6 commits into from
Dec 3, 2019

Conversation

yiicy
Copy link
Collaborator

@yiicy yiicy commented Dec 1, 2019 •
edited
Loading

  • the default library build cxx demo frome .a change to .so
  • add cxx mobilenetv1-ssd detection demo
  • remove mobile_light demo dependency for gflags

注：detection demo所需的opencv lib，会在用户make的过程中下载

@yiicy yiicy force-pushed the cxx_detection_demo branch 2 times, most recently from e03c395 to 668bc96 Compare December 2, 2019 03:47
xyoungli
xyoungli reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@xyoungli xyoungli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opencv的库是没有添加依赖，是需要用户手动去下载吗？
armv7和armv8链接的是同一个opencv的库？

@yiicy yiicy closed this Dec 2, 2019
@yiicy yiicy reopened this Dec 2, 2019
@yiicy
Copy link
Collaborator Author

yiicy commented Dec 2, 2019 •
edited
Loading

opencv的库是没有添加依赖，是需要用户手动去下载吗？
armv7和armv8链接的是同一个opencv的库？

改成了用户在make的demo的时候下载

sangoly
sangoly reviewed Dec 2, 2019
View reviewed changes
Copy link
Collaborator

@sangoly sangoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果CV是Paddle-Lite内的代码非第三方依赖，不应该放在third-party内

lite/CMakeLists.txt Show resolved Hide resolved
sangoly
sangoly reviewed Dec 3, 2019
View reviewed changes
lite/demo/cxx/makefiles/mobile_detection/Makefile.android.armv8 Outdated
@ test -d ${THIRD_PARTY_DIR}/${OPENCV_VERSION} || \
tar -zxvf ${THIRD_PARTY_DIR}/${OPENCV_VERSION}.tar.gz -C ${THIRD_PARTY_DIR}

mobile_detection: mobile_detection.o
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个target需要依赖fetch_opencv吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对的，done

sangoly
sangoly approved these changes Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@sangoly sangoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiicy yiicy merged commit c8b51f8 into PaddlePaddle:develop Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyoungli xyoungli xyoungli left review comments

@sangoly sangoly sangoly approved these changes

@Superjomn Superjomn Awaiting requested review from Superjomn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiicy @sangoly @xyoungli