Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NPU] enhance concat, nearest_interp, bilinear_interp ut #2764

Merged
merged 1 commit into from
Jan 14, 2020
Merged

[NPU] enhance concat, nearest_interp, bilinear_interp ut #2764

merged 1 commit into from
Jan 14, 2020

Conversation

zhupengyang
Copy link
Collaborator

  • 增加concat, nearest_interp, bilinear_interp单测
  • 合并nearest_interp, bilinear_interp单测为interp单测
  • fluid中的interp的infer shape是在compile time，所以只对SizeTensor, Scale, OutSize检查了维度，而没有从中取值，但是lite中infer shape的时候tensor中值都是确定的，因此可以直接取值，而不用设为-1。

FrostML
FrostML approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@FrostML FrostML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for lite/operators/interpolate_op.cc

hong19860320
hong19860320 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit 7a8118b into PaddlePaddle:develop Jan 14, 2020
@zhupengyang zhupengyang deleted the concat-npu-0114 branch January 14, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrostML FrostML FrostML approved these changes

@hong19860320 hong19860320 hong19860320 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhupengyang @FrostML @hong19860320