Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LITE][OPENCL]develop basic image depthwiseconv,passed loop test,test… #2788

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

xiebaiyuan
Copy link
Collaborator

@xiebaiyuan xiebaiyuan commented Jan 19, 2020

  • develop basic image depthwiseconv
  • looped test
  • buffer kernel name fix.

@@ -114,7 +115,7 @@ class DepthwiseConv2dCompute
}

private:
std::string kernel_func_name_{"depthwise_conv2d_3x3"};
std::string kernel_func_name_{"depthwise_conv2d"};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buffer 的方法 不带3x3

Copy link
Collaborator Author

@xiebaiyuan xiebaiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic depthwise impl

@@ -341,6 +342,189 @@ class DepthwiseConv2d3x3s1ComputeFP16Image
std::shared_ptr<cl::Event> event_{new cl::Event};
};

class DepthwiseConv2dBasicComputeFP32Image
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depth conv basic impl..

}
auto& context = ctx_->As<OpenCLContext>();
context.cl_context()->AddKernel(kernel_func_name_,
"image/depthwise_conv2d_basic_kernel.cl",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depthwise_conv2d的buffer的方法需要放到:buffer/的cl文件里

Copy link
Contributor

@ysh329 ysh329 Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看错了,这个是image的实现

Copy link
Contributor

@ysh329 ysh329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants