-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARM] 5x5dw and sgemv support fuse activation, test=develop #2797
Conversation
@@ -466,8 +467,8 @@ TEST(TestConv3x3DWInt8, test_conv3x3_depthwise) { | |||
for (auto& c : {1, 3, 5, 8, 16, 32}) { | |||
std::vector<DDim> dims; | |||
DDim weights_dim({c, 1, 3, 3}); | |||
for (auto& batch : {1, 2}) { | |||
for (auto& h : {1, 3, 15, 19, 75, 32, 28}) { | |||
for (auto& batch : {2}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch==1 为什么不加了。建议加上,这个case 是最常见的。后面类似
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hao
lite/kernels/arm/conv_compute.cc
Outdated
((kw == 5 && stride == 1) || (kw == 5 && stride == 2)); | ||
|
||
bool flag_dw_3x3 = (kw == 3) && (kh == 3) && (stride == 1 || stride == 2); | ||
bool flag_dw_5x5 = (kw == 5 && stride == 1) || (kw == 5 && stride == 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不判断kh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
soga
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
this will cause more time elapse in CI system, but this is necessary