You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@Aganlengzi In PR-CI-Coverage there is problem in all recent PRs File "/paddle/tools/check_pr_approval.py", line 28, in check_approval if review["state"] == "APPROVED":
Can it be fixed somehow?
@chenwhql In the file phi/kernels/cpu/adamw_kernel.cc I used JIT kernel and approval is needed for that. Could you please check this?
@Aganlengzi In PR-CI-Coverage there is problem in all recent PRs File "/paddle/tools/check_pr_approval.py", line 28, in check_approval if review["state"] == "APPROVED":
Can it be fixed somehow?
@Aganlengzi Could you please help with the PR-CI-APPROVAL ?
2022-05-06 05:41:32 2022-05-06 05:41:32 (3.19 MB/s) - 已保存 “bk.txt” [5/5])
2022-05-06 05:41:38 ****************
2022-05-06 05:41:39 0. You must have one RD (chenwhql, MingMingShangTian, YuanRisheng or zyfncg) approval for the including paddle/fluid header in paddle/phi files( paddle/phi/kernels/cpu/adamw_kernel.cc).
lidanqing-intel
changed the title
Add AdamW-CPU FP32 JIT assembly kernel
[Need approval] Add AdamW-CPU FP32 JIT assembly kernel
May 9, 2022
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lidanqing-intel
changed the title
PR types
New features
PR changes
OPs
Describe
This PR adds AdamW JIT assembly kernel. This feature was requested by #41950
Before in AdamW, all params were computed with Eigen
Paddle/paddle/phi/kernels/funcs/adam_functors.h
Line 426 in 34ac7b7
In this PR AdamW JIT implementation, params are calculated with vector instructions in the same loop where params and momentums are calculated.
Results for VGG training script "test_image_classification.py"
100 batches of 128 images
Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz
Average kernel time [ms]